-
Notifications
You must be signed in to change notification settings - Fork 853
feat(build): print error on build flag --output=type=something #6476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iTrooz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I updated the title with the most important change. Would you like me to split the PR into 2 instead ? |
1e9e1eb to
9e02ac7
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
2 similar comments
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
CI failed because of an image pull timeout. |
e346ef4 to
a31731b
Compare
Also make --output=tar,dest=- work Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
a31731b to
5afe04d
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Two things:
--output=tar,dest=-have correct behaviour (streaming to stdout)--output=type=somethinginstead of outputting image to foldertype=something(this is the case whether "something" is a valid type or not)How to verify it
podman build . --output=tar,dest=-podman build --output=type=somethingWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?