Skip to content

Conversation

@iTrooz
Copy link

@iTrooz iTrooz commented Nov 5, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Two things:

  • make build flag --output=tar,dest=- have correct behaviour (streaming to stdout)
  • print error on build flag --output=type=something instead of outputting image to folder type=something (this is the case whether "something" is a valid type or not)

How to verify it

  • Run podman build . --output=tar,dest=-
  • Run podman build --output=type=something

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

make build flag `--output=tar,dest=-` have correct behaviour (streaming to stdout)
print error on build flag `--output=type=INVALID` instead of outputting image to folder `type=INVALID`

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iTrooz
Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iTrooz iTrooz changed the title feat(build): make --output=tar,dest=- work + print error on build flag --output=type=something feat(build): make --output=tar,dest=- work Nov 8, 2025
@iTrooz iTrooz changed the title feat(build): make --output=tar,dest=- work feat(build): print error on build flag --output=type=something Nov 8, 2025
@iTrooz
Copy link
Author

iTrooz commented Nov 8, 2025

I updated the title with the most important change. Would you like me to split the PR into 2 instead ?

@iTrooz iTrooz force-pushed the build_output_flag branch from 1e9e1eb to 9e02ac7 Compare November 8, 2025 20:42
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

2 similar comments
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@iTrooz
Copy link
Author

iTrooz commented Nov 8, 2025

CI failed because of an image pull timeout. TestConformance/header-builtin succeeds locally. I think it should be re-run

@iTrooz iTrooz force-pushed the build_output_flag branch 2 times, most recently from e346ef4 to a31731b Compare November 12, 2025 21:43
Also make --output=tar,dest=- work

Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant