feat: add support for emphasis marks in rich text rendering fixes 587#586
Open
Etienne-Joseph Charles (etiennejcharles) wants to merge 1 commit into
Open
Conversation
Author
|
Fixes #587 |
Contributor
|
Hey 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Introduce Separate
<em>TagsOverview
This PR introduces the use of separate
<em>tags in our codebase to improve semantic HTML usage and accessibility. Existing<i>tags remain unchanged.Background
In our current codebase, there is an overuse of
<i>tags for both emphasis and stylistic purposes. However, these tags serve different purposes:<em>is used to denote text that is emphasized, conveying importance or stress.<i>is typically used for text that is set off from the normal text, often for stylistic purposes, such as foreign words, technical terms, or names of ships.Introducing
<em>tags for emphasis enhances the semantic meaning of our HTML and improves accessibility for users relying on screen readers.Changes Introduced
Added
<em>Tags:<em>tags where text needs to be emphasized, replacing the misuse of<i>tags for this purpose.<i>tags for stylistic purposes as they are.Updated CSS Styles:
<i>for emphasis are now correctly applied to<em>to maintain visual consistency.Accessibility Improvements: