Skip to content

update cosa diff --metal to work on s390x/ppc64le #4364

@dustymabe

Description

@dustymabe

The current implementation assumes that all metal images have an EFI-SYSTEM partition. If this partition is not found, g.findfs_label() will raise an exception, causing the diff operation to fail. This could be an issue for BIOS-only images. To make this more robust, you should handle the case where the EFI partition is not present.

            try:
                efi = g.findfs_label("EFI-SYSTEM")
                g.mount_ro(efi, "/boot/efi")
            except RuntimeError:
                # Not all images have an EFI partition, so we can ignore.
                pass

Originally posted by @gemini-code-assist[bot] in #4360 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions