Skip to content

kola: stop treating scos and rhcos as the same distro #4555

@dustymabe

Description

@dustymabe

We should probably unwind the binding:

if kola.Options.Distribution == "" {
kola.Options.Distribution = kolaDistros[0]
} else if kola.Options.Distribution == "scos" {
// Consider SCOS the same as RHCOS for now
kola.Options.Distribution = "rhcos"
} else if err := validateOption("distro", kola.Options.Distribution, kolaDistros); err != nil {
return err
}

So that we can do things like exclusively run a test just on rhcos and not on scos.

For an example see #4554 where we had to workaround this behavior. The test has Distros: []string{"rhcos"} but the test still ran on scos, which wasn't what we wanted.

Metadata

Metadata

Labels

jirafor syncing to jira

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions