Inconsistent parameter declaration name

[marcelhuberfoo]

Unfortunately, the JNIGenerator is not using the same parameter names in the generated files as for example the ObjCppGenerator does.
This leads to issues reported by clang-tidy when having the readability-inconsistent-declaration-parameter-name check active.
The issue is in the following line generating the prototype, where the " " should have been " c_":

djinni-generator/src/main/scala/djinni/JNIGenerator.scala

Line 373 in 719e0a7

cppMarshal.fqParamType(p.ty) + " " + idCpp.local(p.ident)

like for the body writer here:

djinni-generator/src/main/scala/djinni/JNIGenerator.scala

Line 423 in 719e0a7

cppMarshal.fqParamType(p.ty) + " c_" + idCpp.local(p.ident)

You can use this search to compare the different generator implementations: https://github.com/search?q=repo%3Across-language-cpp%2Fdjinni-generator%20idCpp.local&type=code

I will potentially put up a PR to propose the fix.

[a4z]

Thank you for pointing out this behavior!
I agree that the generated code should work with the tools' default settings.

As far as I can see, this has nothing to do with naming conventions from the used target language, but please cross-check me on that point.

For the PR, please make the tests passing, the existing guide should still work
https://djinni.xlcpp.dev/djinni-generator/developer-guide/