Skip to content

Commit 0efc70f

Browse files
Merge pull request #37 from crowdin/update-source-strings
Update listSourceStrings request
2 parents 7534ada + 354633d commit 0efc70f

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ repositories {
2828
maven { url "https://jitpack.io" }
2929
}
3030
dependencies {
31-
compile "com.github.crowdin:crowdin-api-client-java:1.2.2"
31+
compile "com.github.crowdin:crowdin-api-client-java:1.2.3"
3232
}
3333
```
3434

@@ -44,7 +44,7 @@ dependencies {
4444
<dependency>
4545
<groupId>com.github.crowdin</groupId>
4646
<artifactId>crowdin-api-client-java</artifactId>
47-
<version>1.2.2</version>
47+
<version>1.2.3</version>
4848
</dependency>
4949
```
5050

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ plugins {
77
}
88

99
sourceCompatibility = 8
10-
version '1.2.2'
10+
version '1.2.3'
1111

1212
repositories {
1313
mavenCentral()

src/main/java/com/crowdin/client/sourcestrings/SourceStringsApi.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ public SourceStringsApi(Credentials credentials, ClientConfig clientConfig) {
3434
* @param offset starting offset in the collection (default 0)
3535
* @return list of source strings
3636
*/
37-
public ResponseList<SourceString> listSourceStrings(Long projectId, Long fileId, Integer limit, Integer offset) throws HttpException, HttpBadRequestException {
37+
public ResponseList<SourceString> listSourceStrings(Long projectId, Long fileId, String filter, Integer limit, Integer offset) throws HttpException, HttpBadRequestException {
3838
Map<String, Optional<Object>> queryParams = HttpRequestConfig.buildUrlParams(
3939
"fileId", Optional.ofNullable(fileId),
40+
"filter", Optional.ofNullable(filter),
4041
"limit", Optional.ofNullable(limit),
4142
"offset", Optional.ofNullable(offset)
4243
);

src/test/java/com/crowdin/client/sourcestrings/SourceStringsApiTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public List<RequestMock> getMocks() {
3939

4040
@Test
4141
public void listStringsTest() {
42-
ResponseList<SourceString> sourceStringResponseList = this.getSourceStringsApi().listSourceStrings(projectId, null, null, null);
42+
ResponseList<SourceString> sourceStringResponseList = this.getSourceStringsApi().listSourceStrings(projectId, null, null, null, null);
4343
assertEquals(sourceStringResponseList.getData().size(), 1);
4444
assertEquals(sourceStringResponseList.getData().get(0).getData().getId(), id);
4545
assertEquals(sourceStringResponseList.getData().get(0).getData().getText(), text);

0 commit comments

Comments
 (0)