Allow substitution of "{date}" in @author tag. #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@cschlosser, would you welcome PRs for very specific use cases like this? I needed something like: But I don't think there's a lot of people who will be using it this way. Do you think it would be better if I generalize this change to making all substitutions work for all tags? |
Owner
|
Hi @helixquar , It's fine as is. Please just also address the other two checkboxes and then I will merge it. |
AJIOB
reviewed
Jun 6, 2023
| protected generateAuthorTag(lines: string[]) { | ||
| let dateFormat: string = "YYYY-MM-DD"; // Default to ISO standard if not defined | ||
| if ( this.cfg.Generic.dateFormat.trim().length !== 0) { | ||
| dateFormat = this.cfg.Generic.dateFormat; // Overwrite with user format |
There was a problem hiding this comment.
Suggested change
| dateFormat = this.cfg.Generic.dateFormat; // Overwrite with user format | |
| dateFormat = this.cfg.Generic.dateFormat.trim(); // Overwrite with user format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
In addition to
{author}and{email}, this PR adds{date}to the@authortag.Added gif to README
Added unit test