Add HeaderCell to simplify humanizing names

Author: alexdunae

lib/spreadsheet_exporter.rb

@@ -3,6 +3,7 @@
 require_relative './spreadsheet_exporter/xlsx'
 require 'active_support'
 require 'active_support/core_ext/object/json'
+require 'active_support/core_ext/hash/reverse_merge'
 
 module SpreadsheetExporter
   VALIDATION_ERROR_TYPES = %w[stop warning information].freeze

lib/spreadsheet_exporter/spreadsheet.rb

@@ -1,5 +1,12 @@
 # TODO: Find out why we can't detect arrays properly and must resort to crappy class.name comparison
 module SpreadsheetExporter
+  HeaderCell = Struct.new(:attribute_name, :human_attribute_name) do
+    def to_s
+      human_attribute_name.presence || attribute_name
+    end
+  end
+
+
   module Spreadsheet
     def self.from_objects(objects, options = {})
       headers = []
@@ -15,17 +22,23 @@ def self.from_objects(objects, options = {})
           get_values(object.as_json(options))
         end
 
-        headers |= data.keys
+        headers |= data.keys.map { |v| HeaderCell.new(v) }
         rows << data
       end
 
       # Create the csv, ensuring to place each row's attributes under the appropriate header (since rows may not have all the same attributes)
       [].tap do |spreadsheet|
-        spreadsheet << (options[:humanize_headers_class] ? han(options[:humanize_headers_class], headers) : headers)
+        if options[:humanize_headers_class]
+          headers = han(headers, **options)
+        end
+
+        spreadsheet << headers
+
         rows.each do |row|
           sorted_row = []
           row.each do |header, value|
-            sorted_row[headers.index(header)] = value
+            col_index = headers.find_index { |h| h.attribute_name == header }
+            sorted_row[col_index] = value
           end
 
           spreadsheet << sorted_row
@@ -35,14 +48,14 @@ def self.from_objects(objects, options = {})
 
     # Return an array of human_attribute_name's
     # Used by the CSV Import/Export process to match CSV headers to model attribute names
-    def self.han(klass, *attributes)
-      options = attributes.extract_options!
+    def self.han(headers, humanize_headers_class:, downcase: false, **)
+      headers.flatten!
 
-      attributes.flatten!
-      attributes.collect! {|attribute| klass.human_attribute_name(attribute) }
-      attributes.collect!(&:downcase) if options[:downcase]
-
-      return attributes.many? ? attributes : attributes.first
+      headers.collect! do |header|
+        header.human_attribute_name = humanize_headers_class.human_attribute_name(header.attribute_name)
+        header.human_attribute_name.downcase! if downcase
+        header
+      end
     end
 
     def self.get_values(node, current_header = nil)

lib/spreadsheet_exporter/xlsx.rb

@@ -27,9 +27,9 @@ def self.from_spreadsheet(spreadsheet, options = {})
       column_indexes = {}
 
       # Write header row
-      Array(spreadsheet.first).each_with_index do |column_name, col|
-        worksheet.write(0, col, column_name, header_format)
-        column_indexes[column_name] = col
+      Array(spreadsheet.first).each_with_index do |header, col|
+        worksheet.write(0, col, header.to_s, header_format)
+        column_indexes[header.attribute_name] = col
       end
 
       Array(spreadsheet[1..]).each_with_index do |values, row|
@@ -101,25 +101,10 @@ def self.add_data_source(workbook, data_sheet, data_key, data_values, column_ind
       defined_name
     end
 
-    # TODO: we should DRY this up with the Spreadsheet.from_objects logic
-    def self.rewrite_validation_column_names(column_validations, options)
-      return column_validations unless options["humanize_headers_class"]
-
-      klass = options["humanize_headers_class"]
-
-      column_validations.each_with_object({}) do |(attribute, v), obj|
-        rewritten = klass.human_attribute_name(attribute)
-        rewritten.downcase! if options[:downcase]
-        obj[rewritten] = v
-      end
-    end
-
     def self.add_worksheet_validation(workbook, worksheet, column_indexes, data_sources, header_format, options = {})
       column_validations = options.fetch("validations", {}) || {}
       return if column_validations.empty?
 
-      column_validations = rewrite_validation_column_names(column_validations, options)
-
       column_validations.each do |column_name, column_validation|
         column_index = column_indexes[column_name]
 
@@ -133,7 +118,8 @@ def self.add_worksheet_validation(workbook, worksheet, column_indexes, data_sour
         if column_validation.indirect_built_from
           parent_column_index = column_indexes[column_validation.indirect_built_from]
 
-          (1..100).each do |row_index|
+          # TODO: que pasa
+          (1..20).each do |row_index|
             indirect_cell = xl_rowcol_to_cell(row_index, parent_column_index, false, false)
             defined_name = "INDIRECT(\"#{column_validation.data_source}\" & \"_\" & SUBSTITUTE(#{indirect_cell}, \" \", \"\"))"
 

test.rb

@@ -53,5 +53,15 @@
     )
   }
 }
+class Yoda
+  def self.human_attribute_name(att)
+    att.reverse
+  end
+end
+
+# debugger
+# SpreadsheetExporter::CSV.from_objects(data, :humanize_headers_class => Yoda)
+
+options[:humanize_headers_class] = Yoda
 
 File.binwrite("output.xlsx", SpreadsheetExporter::XLSX.from_objects(data, options))