test: fix tests that dont expect a connected wallet

Author: 0xAlunara

packages/curve-ui-kit/src/features/connect-wallet/lib/wagmi/useWagmiConfig.ts

@@ -3,7 +3,7 @@ import type { Chain } from 'viem'
 import { generatePrivateKey } from 'viem/accounts'
 import { mapRecord, recordValues } from '@curvefi/prices-api/objects.util'
 import type { NetworkMapping } from '@ui/utils'
-import { Chain as ChainEnum, isCypress } from '@ui-kit/utils'
+import { Chain as ChainEnum, isCypress, noCypressTestConnector } from '@ui-kit/utils'
 import { createChainFromNetwork } from './chains'
 import { defaultGetRpcUrls } from './rpc'
 import { createTransportFromNetwork } from './transports'
@@ -22,13 +22,14 @@ export const useWagmiConfig = <T extends NetworkMapping>(networks: T | undefined
     return createWagmiConfig({
       chains,
       transports: mapRecord(networks, (_, network) => createTransportFromNetwork(network, defaultGetRpcUrls)),
-      ...(isCypress && {
-        connectors: [
-          createTestConnector({
-            privateKey: generatePrivateKey(),
-            chain: chains.find((chain) => chain.id === ChainEnum.Ethereum)!,
-          })!,
-        ],
-      }),
+      ...(isCypress &&
+        !noCypressTestConnector && {
+          connectors: [
+            createTestConnector({
+              privateKey: generatePrivateKey(),
+              chain: chains.find((chain) => chain.id === ChainEnum.Ethereum)!,
+            })!,
+          ],
+        }),
     })
   }, [networks])

packages/curve-ui-kit/src/utils/index.ts

@@ -18,6 +18,7 @@ export enum ReleaseChannel {
 }
 
 export const isCypress = Boolean((window as { Cypress?: unknown }).Cypress)
+export const noCypressTestConnector = Boolean((window as { CypressNoTestConnector?: unknown }).CypressNoTestConnector)
 
 const isDefaultBeta =
   process.env.NODE_ENV === 'development' ||

tests/cypress/e2e/all/header.cy.ts

@@ -27,7 +27,7 @@ describe('Header', () => {
       viewport = oneDesktopViewport()
       cy.viewport(...viewport)
       route = oneAppRoute()
-      cy.visit(`/${route}`)
+      cy.visitWithoutTestConnector(route)
       waitIsLoaded(route)
     })
 
@@ -89,7 +89,7 @@ describe('Header', () => {
       viewport = oneMobileOrTabletViewport()
       cy.viewport(...viewport)
       route = oneAppRoute()
-      cy.visit(`/${route}`)
+      cy.visitWithoutTestConnector(route)
       waitIsLoaded(route)
     })
 

tests/cypress/e2e/main/basic.cy.ts

@@ -37,7 +37,7 @@ describe('Basic Access Test', () => {
   })
 
   it('should load for lite networks', () => {
-    cy.visit('/dex/corn/pools')
+    cy.visitWithoutTestConnector('dex/corn/pools')
     cy.title(LOAD_TIMEOUT).should('equal', 'Pools - Curve')
     cy.url().should('include', '/dex/corn/pools')
     cy.contains(/LBTC\/wBTCN/i, LOAD_TIMEOUT).should('be.visible')

tests/cypress/e2e/main/dex-markets.cy.ts

@@ -4,7 +4,7 @@ import { setShowSmallPools } from '@cy/support/helpers/user-profile'
 import { API_LOAD_TIMEOUT, type Breakpoint, LOAD_TIMEOUT, oneViewport } from '@cy/support/ui'
 import { SMALL_POOL_TVL } from '@ui-kit/features/user-profile/store'
 
-const PATH = '/dex/arbitrum/pools/'
+const PATH = 'dex/arbitrum/pools/'
 
 // Parse compact USD strings like "$1.2M", "$950K", "$0", "-"
 function parseCompactUsd(value: string): number {
@@ -30,7 +30,7 @@ function visitAndWait(
 ) {
   cy.viewport(width, height)
   const { query } = options ?? {}
-  cy.visit(`${PATH}${query ? `?${new URLSearchParams(query)}` : ''}`, options)
+  cy.visitWithoutTestConnector(`${PATH}${query ? `?${new URLSearchParams(query)}` : ''}`, options)
   cy.get('[data-testid^="data-table-row-"]', API_LOAD_TIMEOUT).should('have.length.greaterThan', 0)
   if (query?.['page']) {
     cy.get('[data-testid="table-pagination"]').should('be.visible')

tests/cypress/e2e/main/pool-page.cy.ts

@@ -1,16 +1,17 @@
 import { oneFloat, oneOf } from '@cy/support/generators'
+import type { AppRoute } from '@cy/support/routes'
 import { LOAD_TIMEOUT } from '@cy/support/ui'
 
 describe('Pool page', () => {
-  const path = `/dex/${oneOf(
+  const path: AppRoute = `dex/${oneOf(
     'ethereum/pools/factory-tricrypto-0',
     'ethereum/pools/factory-stable-ng-561',
     'arbitrum/pools/2pool',
     'corn/pools/factory-stable-ng-0',
   )}/deposit`
 
   it('should update slippage settings', () => {
-    cy.visit(path)
+    cy.visitWithoutTestConnector(path)
     cy.get('[data-testid="tab-deposit"]', LOAD_TIMEOUT).should('have.class', 'Mui-selected')
     cy.get('[data-testid="borrow-slippage-value"]').contains(path.includes('crypto') ? '0.10%' : '0.03%')
     cy.get('[data-testid="slippage-settings-button"]').click()

tests/cypress/e2e/main/swap.cy.ts

@@ -5,7 +5,7 @@ describe('DEX Swap', () => {
   const TO_ETH = '0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE'
 
   it('shows quotes via router API when disconnected', () => {
-    cy.visit(`/dex/ethereum/swap?from=${FROM_USDT}&to=${TO_ETH}`)
+    cy.visitWithoutTestConnector(`dex/ethereum/swap?from=${FROM_USDT}&to=${TO_ETH}`)
     cy.get('[data-testid="btn-connect-wallet"]', LOAD_TIMEOUT).should('be.enabled')
     cy.get(`[data-testid="token-icon-${FROM_USDT}"]`, LOAD_TIMEOUT).should('be.visible')
 

tests/cypress/support/e2e.ts

@@ -1 +1,28 @@
-// This file is imported automatically before e2e tests run. Try to keep it empty if possible
+import type { AppRoute } from './routes'
+
+declare global {
+  interface Window {
+    CypressNoTestConnector?: string
+  }
+
+  // eslint-disable-next-line @typescript-eslint/no-namespace
+  namespace Cypress {
+    interface Chainable<Subject = any> {
+      visitWithoutTestConnector(route: AppRoute, options?: Partial<Cypress.VisitOptions>): Chainable<AUTWindow>
+    }
+  }
+}
+
+/**
+ * For most of our e2e tests we have a wagmi test connect that auto-connects, so there's a wallet available.
+ * However, in some cases we want to test functionality without a wallet connected.
+ */
+Cypress.Commands.add('visitWithoutTestConnector', (route: AppRoute, options?: Partial<Cypress.VisitOptions>) =>
+  cy.visit(`/${route}`, {
+    ...options,
+    onBeforeLoad(win) {
+      win.CypressNoTestConnector = 'true'
+      options?.onBeforeLoad?.(win)
+    },
+  }),
+)