Merge pull request #1564 from curvefi/refactor/phishing-warn

refactor: remove unused modal

Author: DanielSchiavini

packages/curve-ui-kit/src/hooks/useLocalStorage.ts

@@ -1,15 +1,15 @@
 import lodash from 'lodash'
-import { SetStateAction, useCallback, useMemo } from 'react'
+import { useMemo } from 'react'
 import type { Address } from '@curvefi/prices-api'
 import type { ColumnFiltersState } from '@tanstack/table-core'
 import type { VisibilityVariants } from '@ui-kit/shared/ui/DataTable/visibility.types'
 import { defaultReleaseChannel, ReleaseChannel } from '@ui-kit/utils'
-import { GetAndSet, type MigrationOptions, useStoredState } from './useStoredState'
+import { type MigrationOptions, useStoredState } from './useStoredState'
 
 const { kebabCase } = lodash
 
 // old keys that are not used anymore - clean them up
-window.localStorage.removeItem('isNewDomainNotificationSeen')
+window.localStorage.removeItem('phishing-warning-dismissed')
 
 function getFromLocalStorage<T>(storageKey: string): T | null {
   if (typeof window === 'undefined') {
@@ -78,14 +78,3 @@ export const useFavoriteMarkets = () => {
   const initialValue = useMemo(() => [], [])
   return useLocalStorage<Address[]>('favoriteMarkets', initialValue)
 }
-
-export const usePhishingWarningDismissed = (): GetAndSet<Date | null> => {
-  const [dateStr, setDateStr] = useLocalStorage<string | null>(`phishing-warning-dismissed`, null)
-  const date = useMemo(() => (dateStr == null ? null : new Date(dateStr)), [dateStr])
-  const setDate = useCallback(
-    (setter: SetStateAction<Date | null>) =>
-      setDateStr((typeof setter === 'function' ? setter(date) : setter)?.toISOString() ?? null),
-    [setDateStr, date],
-  )
-  return [date, setDate] as const
-}

packages/curve-ui-kit/src/widgets/Header/PhishingWarningModal.tsx

@@ -30,10 +30,7 @@ describe('Header', () => {
       cy.viewport(...viewport)
       route = oneAppRoute()
       cy.visit(`/${route}`, {
-        onBeforeLoad: (win) => {
-          win.localStorage.setItem('phishing-warning-dismissed', `"${new Date().toISOString()}"`)
-          isDarkMode = checkIsDarkMode(win)
-        },
+        onBeforeLoad: (win) => (isDarkMode = checkIsDarkMode(win)),
       })
       waitIsLoaded(route)
     })
@@ -98,9 +95,7 @@ describe('Header', () => {
       viewport = oneMobileOrTabletViewport()
       cy.viewport(...viewport)
       route = oneAppRoute()
-      cy.visit(`/${route}`, {
-        onBeforeLoad: (win) => win.localStorage.setItem('phishing-warning-dismissed', `"${new Date().toISOString()}"`),
-      })
+      cy.visit(`/${route}`)
       waitIsLoaded(route)
     })
 

tests/cypress/e2e/all/header.cy.ts

@@ -13,9 +13,7 @@ describe('Legal', () => {
     const viewport = oneOf(oneDesktopViewport, oneTabletViewport)()
     it(`it should contain footer legal link for ${viewport.join('x')}`, () => {
       cy.viewport(...viewport)
-      cy.visit(`/${oneAppPath() || 'dex'}/`, {
-        onBeforeLoad: (win) => win.localStorage.setItem('phishing-warning-dismissed', `"${new Date().toISOString()}"`),
-      })
+      cy.visit(`/${oneAppPath() || 'dex'}/`)
 
       //Navigate to legal route from footer link
       cy.get(`[data-testid='footer']`, LOAD_TIMEOUT).should('be.visible')
@@ -29,9 +27,7 @@ describe('Legal', () => {
     const [width, height] = oneViewport()
     it(`should contain multiple tabs for ${width}x${height}`, () => {
       cy.viewport(width, height)
-      cy.visit(`/${oneAppPath() || 'dex'}/ethereum/legal`, {
-        onBeforeLoad: (win) => win.localStorage.setItem('phishing-warning-dismissed', `"${new Date().toISOString()}"`),
-      })
+      cy.visit(`/${oneAppPath() || 'dex'}/ethereum/legal`)
 
       // Make sure there's tabs available and click one.
       cy.get(`[data-testid='legal-page']`, LOAD_TIMEOUT).should('be.visible')

tests/cypress/e2e/all/legal.cy.ts

@@ -352,11 +352,7 @@ describe(`LlamaLend Storage Migration`, () => {
 
 function visitAndWait([width, height]: [number, number, Breakpoint], options?: Partial<Cypress.VisitOptions>) {
   cy.viewport(width, height)
-  cy.visit('/llamalend/ethereum/markets/', {
-    onBeforeLoad: (win) => win.localStorage.setItem('phishing-warning-dismissed', `"${new Date().toISOString()}"`),
-    ...LOAD_TIMEOUT,
-    ...options,
-  })
+  cy.visit('/llamalend/ethereum/markets/', { ...LOAD_TIMEOUT, ...options })
   cy.get('[data-testid="data-table"]', LOAD_TIMEOUT).should('be.visible')
 }