Skip to content

Commit 41fa8b0

Browse files
committed
refactor(appkit): move agent exports to @databricks/appkit/beta
fromPlugin, isFromPluginMarker, AgentTools, FromPluginMarker added in this PR are exported from beta. Also fixes agents.ts import paths from Option A rewrite (normalize-result, consume-adapter-stream, tool-dispatch now in core/agent/).
1 parent d42173c commit 41fa8b0

3 files changed

Lines changed: 78 additions & 76 deletions

File tree

packages/appkit/src/beta.ts

Lines changed: 58 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,61 @@
1-
// Beta plugins -- APIs may change between minor releases.
2-
// These plugins are on a path to GA and will graduate.
3-
// Import from '@databricks/appkit' once a plugin graduates to GA.
1+
// Beta plugins and APIs -- may change between minor releases.
2+
// These are on a path to GA and will graduate to '@databricks/appkit'.
43
//
5-
// The exports below are auto-generated from each plugin's manifest.json
4+
// Plugin factory exports are auto-generated from each plugin's manifest.json
65
// "stability" field. See tools/generate-plugin-entries.ts.
6+
7+
// Agent types from shared
8+
export type {
9+
AgentAdapter,
10+
AgentEvent,
11+
AgentInput,
12+
AgentRunContext,
13+
AgentToolDefinition,
14+
Message,
15+
Thread,
16+
ThreadStore,
17+
ToolAnnotations,
18+
ToolProvider,
19+
} from "shared";
20+
// Agent runtime
21+
export { createAgent } from "./core/agent/create-agent";
22+
export {
23+
type RunAgentInput,
24+
type RunAgentResult,
25+
runAgent,
26+
} from "./core/agent/run-agent";
27+
// Tool authoring primitives
28+
export {
29+
type FunctionTool,
30+
type HostedTool,
31+
isFunctionTool,
32+
isHostedTool,
33+
mcpServer,
34+
type ToolConfig,
35+
tool,
36+
} from "./core/agent/tools";
37+
38+
// Agent types
39+
export type {
40+
AgentDefinition,
41+
AgentsPluginConfig,
42+
AgentTool,
43+
AgentTools,
44+
AutoInheritToolsConfig,
45+
BaseSystemPromptOption,
46+
FromPluginMarker,
47+
PromptContext,
48+
RegisteredAgent,
49+
ResolvedToolEntry,
50+
ToolkitEntry,
51+
ToolkitOptions,
52+
} from "./plugins/agents";
53+
export {
54+
agentIdFromMarkdownPath,
55+
fromPlugin,
56+
isFromPluginMarker,
57+
isToolkitEntry,
58+
loadAgentFromFile,
59+
loadAgentsFromDir,
60+
} from "./plugins/agents";
761
export * from "./plugins/beta-exports.generated";

packages/appkit/src/index.ts

Lines changed: 8 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,11 @@
77

88
// Types from shared
99
export type {
10-
AgentAdapter,
11-
AgentEvent,
12-
AgentInput,
13-
AgentRunContext,
14-
AgentToolDefinition,
1510
BasePluginConfig,
1611
CacheConfig,
1712
IAppRouter,
18-
Message,
1913
PluginData,
2014
StreamExecutionSettings,
21-
Thread,
22-
ThreadStore,
23-
ToolProvider,
2415
} from "shared";
2516
export { isSQLTypeMarker, sql } from "shared";
2617
export { CacheManager } from "./cache";
@@ -44,12 +35,6 @@ export {
4435
} from "./connectors/lakebase";
4536
export { getExecutionContext } from "./context";
4637
export { createApp } from "./core";
47-
export { createAgent } from "./core/agent/create-agent";
48-
export {
49-
type RunAgentInput,
50-
type RunAgentResult,
51-
runAgent,
52-
} from "./core/agent/run-agent";
5338
// Errors
5439
export {
5540
AppKitError,
@@ -69,45 +54,6 @@ export {
6954
type ToPlugin,
7055
toPlugin,
7156
} from "./plugin";
72-
export * from "./plugins/ga-exports.generated";
73-
export type {
74-
AgentDefinition,
75-
AgentTools,
76-
AgentsPluginConfig,
77-
AgentTool,
78-
AutoInheritToolsConfig,
79-
BaseSystemPromptOption,
80-
FromPluginMarker,
81-
PromptContext,
82-
RegisteredAgent,
83-
ResolvedToolEntry,
84-
ToolkitEntry,
85-
ToolkitOptions,
86-
} from "./plugins/agents";
87-
export {
88-
agentIdFromMarkdownPath,
89-
fromPlugin,
90-
isFromPluginMarker,
91-
isToolkitEntry,
92-
loadAgentFromFile,
93-
loadAgentsFromDir,
94-
} from "./plugins/agents";
95-
export type {
96-
IJobsConfig,
97-
JobAPI,
98-
JobConfig,
99-
JobHandle,
100-
JobsExport,
101-
} from "./plugins/jobs";
102-
export {
103-
type FunctionTool,
104-
type HostedTool,
105-
isFunctionTool,
106-
isHostedTool,
107-
mcpServer,
108-
type ToolConfig,
109-
tool,
110-
} from "./core/agent/tools";
11157
// Files plugin types (for custom policy authoring)
11258
export type {
11359
FileAction,
@@ -120,6 +66,14 @@ export {
12066
READ_ACTIONS,
12167
WRITE_ACTIONS,
12268
} from "./plugins/files/policy";
69+
export * from "./plugins/ga-exports.generated";
70+
export type {
71+
IJobsConfig,
72+
JobAPI,
73+
JobConfig,
74+
JobHandle,
75+
JobsExport,
76+
} from "./plugins/jobs";
12377
export type {
12478
EndpointConfig,
12579
ServingEndpointEntry,

packages/appkit/src/plugins/agents/agents.ts

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,15 @@ import type {
1616
} from "shared";
1717
import { AppKitMcpClient, buildMcpHostPolicy } from "../../connectors/mcp";
1818
import { getWorkspaceClient } from "../../context";
19+
import { consumeAdapterStream } from "../../core/agent/consume-adapter-stream";
1920
import { isFromPluginMarker } from "../../core/agent/from-plugin";
2021
import { loadAgentsFromDir } from "../../core/agent/load-agents";
21-
import { normalizeToolResult } from "./normalize-result";
22+
import { normalizeToolResult } from "../../core/agent/normalize-result";
2223
import {
2324
buildBaseSystemPrompt,
2425
composeSystemPrompt,
2526
} from "../../core/agent/system-prompt";
26-
import { consumeAdapterStream } from "./consume-adapter-stream";
27-
import { agentStreamDefaults } from "./defaults";
28-
import { EventChannel } from "./event-channel";
29-
import { AgentEventTranslator } from "./event-translator";
30-
import { createLogger } from "../../logging/logger";
31-
import { Plugin, toPlugin } from "../../plugin";
32-
import type { PluginManifest } from "../../registry";
33-
import manifest from "./manifest.json";
34-
import {
35-
approvalRequestSchema,
36-
chatRequestSchema,
37-
invocationsRequestSchema,
38-
} from "./schemas";
39-
import { InMemoryThreadStore } from "./thread-store";
40-
import { ToolApprovalGate } from "./tool-approval-gate";
41-
import { dispatchToolCall } from "./tool-dispatch";
27+
import { dispatchToolCall } from "../../core/agent/tool-dispatch";
4228
import { resolveToolkitFromProvider } from "../../core/agent/toolkit-resolver";
4329
import {
4430
functionToolToDefinition,
@@ -62,6 +48,13 @@ import { agentStreamDefaults } from "./defaults";
6248
import { EventChannel } from "./event-channel";
6349
import { AgentEventTranslator } from "./event-translator";
6450
import manifest from "./manifest.json";
51+
import {
52+
approvalRequestSchema,
53+
chatRequestSchema,
54+
invocationsRequestSchema,
55+
} from "./schemas";
56+
import { InMemoryThreadStore } from "./thread-store";
57+
import { ToolApprovalGate } from "./tool-approval-gate";
6558

6659
const logger = createLogger("agents");
6760

@@ -388,7 +381,8 @@ export class AgentsPlugin extends Plugin implements ToolProvider {
388381
this.resolveFromPluginMarkers(agentName, toolsRecord, index);
389382

390383
// 3. Explicit tools (toolkit entries, function tools, hosted tools)
391-
const hostedToCollect: import("../../core/agent/tools/hosted-tools").HostedTool[] = [];
384+
const hostedToCollect: import("../../core/agent/tools/hosted-tools").HostedTool[] =
385+
[];
392386
for (const [key, tool] of Object.entries(toolsRecord)) {
393387
if (isToolkitEntry(tool)) {
394388
index.set(key, {

0 commit comments

Comments
 (0)