fix update

Author: shreyas-goenka

bundle/direct/dresources/adapter.go

@@ -220,8 +220,7 @@ func (a *Adapter) initMethods(resource any) error {
 		return err
 	}
 
-	// Optional methods with varying signatures:
-
+	// Optional methods:
 	a.doUpdateWithChanges, err = calladapt.PrepareCall(resource, calladapt.TypeOf[IResource](), "DoUpdateWithChanges")
 	if err != nil {
 		return err

bundle/direct/dresources/model_serving_endpoint.go

@@ -10,7 +10,6 @@ import (
 	"github.com/databricks/cli/libs/utils"
 	"github.com/databricks/databricks-sdk-go"
 	"github.com/databricks/databricks-sdk-go/service/serving"
-	"golang.org/x/sync/errgroup"
 )
 
 type ResourceModelServingEndpoint struct {
@@ -141,6 +140,10 @@ func (r *ResourceModelServingEndpoint) WaitAfterCreate(ctx context.Context, conf
 	return r.waitForEndpointReady(ctx, config.Name)
 }
 
+func (r *ResourceModelServingEndpoint) WaitAfterUpdate(ctx context.Context, config *serving.CreateServingEndpoint) (*RefreshOutput, error) {
+	return r.waitForEndpointReady(ctx, config.Name)
+}
+
 func (r *ResourceModelServingEndpoint) updateAiGateway(ctx context.Context, id string, aiGateway *serving.AiGatewayConfig) error {
 	if aiGateway == nil {
 		req := serving.PutAiGatewayRequest{
@@ -277,42 +280,42 @@ func (r *ResourceModelServingEndpoint) hasFieldChange(changes *deployplan.Change
 	if changes == nil {
 		return false
 	}
-	_, ok := changes.Local[fieldPath]
-	return ok
+	_, localChange := changes.Local[fieldPath]
+	_, remoteChange := changes.Remote[fieldPath]
+	return localChange || remoteChange
 }
 
 func (r *ResourceModelServingEndpoint) DoUpdateWithChanges(ctx context.Context, id string, config *serving.CreateServingEndpoint, changes *deployplan.Changes) (*RefreshOutput, error) {
-	errGroup := errgroup.Group{}
-
+	var err error
 	if r.hasFieldChange(changes, "ai_gateway") {
-		errGroup.Go(func() error {
-			return r.updateAiGateway(ctx, id, config.AiGateway)
-		})
+		err = r.updateAiGateway(ctx, id, config.AiGateway)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	if r.hasFieldChange(changes, "config") {
-		errGroup.Go(func() error {
-			return r.updateConfig(ctx, id, config.Config)
-		})
+		err = r.updateConfig(ctx, id, config.Config)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	if r.hasFieldChange(changes, "email_notifications") {
-		errGroup.Go(func() error {
-			return r.updateNotifications(ctx, id, config.EmailNotifications)
-		})
+		err = r.updateNotifications(ctx, id, config.EmailNotifications)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	if r.hasFieldChange(changes, "tags") {
-		errGroup.Go(func() error {
-			return r.updateTags(ctx, id, config.Tags)
-		})
-	}
-
-	if err := errGroup.Wait(); err != nil {
-		return nil, err
+		err = r.updateTags(ctx, id, config.Tags)
+		if err != nil {
+			return nil, err
+		}
 	}
 
-	return r.waitForEndpointReady(ctx, id)
+	return nil, nil
 }
 
 func (r *ResourceModelServingEndpoint) DoDelete(ctx context.Context, id string) error {