fix(hub): preserve killed PTY status

Author: dvcolomban

packages/hub/src/node/__tests__/host-terminals.test.ts

@@ -476,9 +476,11 @@ describe('devframeTerminalHost interactive PTY sessions', () => {
   })
 
   itPty('getResult() marks a terminated PTY run as killed', async () => {
-    expect.assertions(4)
+    expect.assertions(6)
 
     const { host } = createTerminalHost()
+    const updates: string[] = []
+    host.events.on('terminals:session:updated', session => updates.push(session.status))
 
     const session = await host.startPtySession({
       command: NODE,
@@ -502,6 +504,8 @@ describe('devframeTerminalHost interactive PTY sessions', () => {
       await expect(result).resolves.toHaveProperty('signal', undefined)
     else
       await expect(result).resolves.toHaveProperty('signal', expect.any(Number))
+    expect(session.status).toBe('stopped')
+    expect(updates).not.toContain('error')
   })
 
   itPty('getResult() isolates the previous PTY run after restart()', async () => {

packages/hub/src/node/host-terminals.ts

@@ -468,10 +468,10 @@ export class DevframeTerminalsHost implements DevframeTerminalsHostType {
           return
         closeStream()
         /**
-         * A signal kill (terminate()/restart()) and a clean exit are deliberate stops.
-         * Only an unsignalled non-zero exit code is a crash, matching the child-process path.
+         * Killed runs and clean exits are stopped. Only a non-killed non-zero exit
+         * code is a crash, matching the child-process path.
          */
-        markStatus(signal === 0 && exitCode !== 0 ? 'error' : 'stopped')
+        markStatus(!killed && exitCode !== 0 ? 'error' : 'stopped')
       })
       currentResult = {
         get pid() {