refactor(hub): minimize bakeHubStatic change surface

Ablation of the previous commit dropped two deltas that no tested or
in-repo path depends on:

- Removed the `resolveFrom` field added to devframe's core `buildStaticDirs`
  (types/views + host-views). No devframe in the repo declares RemoteAssets
  client assets, and string dist dirs ignore resolveFrom, so re-resolving in
  bakeHubStatic without it is equivalent. Confines the change to @devframes/hub.
- Removed `HubMountedFrame.hasClientAssets` (and serveDevframeAssets' boolean
  return): whether a frame served its own SPA is derivable from
  ctx.views.buildStaticDirs, so bakeHubStatic derives the per-frame meta
  targets instead of carrying an extra field on the public type.

Author: antfubot

packages/devframe/src/node/host-views.ts

@@ -7,7 +7,7 @@ export class DevframeViewHost implements DevframeViewHostType {
   /**
    * @internal
    */
-  public buildStaticDirs: { baseUrl: string, source: StaticAssetsSource, resolveFrom?: string | null }[] = []
+  public buildStaticDirs: { baseUrl: string, source: StaticAssetsSource }[] = []
 
   constructor(
     public readonly context: DevframeNodeContext,
@@ -30,7 +30,7 @@ export class DevframeViewHost implements DevframeViewHostType {
       throw diagnostics.DF0008({ distDir: resolved })
     }
 
-    this.buildStaticDirs.push({ baseUrl, source, resolveFrom: defaultResolveFrom })
+    this.buildStaticDirs.push({ baseUrl, source })
     this.context.host.mountStatic(baseUrl, resolved)
   }
 }

packages/devframe/src/types/views.ts

@@ -2,15 +2,9 @@ import type { StaticAssetsSource } from './remote-assets'
 
 export interface DevframeViewHost {
   /**
-   * Static mounts registered through {@link DevframeViewHost.hostStatic}, in
-   * registration order, each carrying the `resolveFrom` base it was mounted
-   * with so a build step can re-resolve a remote source identically. A static
-   * build that assembles the context itself (rather than serving it live)
-   * copies these into its output.
-   *
    * @internal
    */
-  buildStaticDirs: { baseUrl: string, source: StaticAssetsSource, resolveFrom?: string | null }[]
+  buildStaticDirs: { baseUrl: string, source: StaticAssetsSource }[]
   /**
    * Helper to host static files
    * - In `dev` mode, it will register middleware to `viteServer.middlewares` to host the static files

packages/hub/src/node/__tests__/install-devframe.test.ts

@@ -28,7 +28,6 @@ function createContext(): DevframeHubContext {
       hostStatic: vi.fn((baseUrl: string, source: unknown) => {
         mountStatic(baseUrl, source as string)
       }),
-      buildStaticDirs: [],
     },
     frames: [],
     /**

packages/hub/src/node/bake.ts

@@ -110,9 +110,9 @@ export async function bakeHubStatic(ctx: DevframeHubContext, options: BakeHubSta
  */
 async function copyBuildStatics(ctx: DevframeHubContext, resolveOutPath: (urlBase: string) => string): Promise<void> {
   const storageDir = ctx.host.getStorageDir('project')
-  for (const { baseUrl, source, resolveFrom } of ctx.views.buildStaticDirs) {
+  for (const { baseUrl, source } of ctx.views.buildStaticDirs) {
     const target = resolveOutPath(baseUrl)
-    const resolved = resolveStaticAssetsSource(source, storageDir, resolveFrom)
+    const resolved = resolveStaticAssetsSource(source, storageDir)
     await fs.mkdir(dirname(target), { recursive: true })
     if (typeof resolved === 'string')
       await fs.cp(resolved, target, { recursive: true })
@@ -188,10 +188,10 @@ async function writeHubIndex(
 
 /**
  * Write the `backend: 'static'` connection meta at the hub base, and a copy at
- * every frame base that served its own SPA whose `baseUrl` points relative
- * resolution (the RPC dump) back at the hub's own meta, so a frame SPA that
- * fetched its per-frame copy (instead of inheriting the host page's connection)
- * still finds the shared dump.
+ * every frame base that served its own SPA (i.e. registered a static mount at
+ * that base) whose `baseUrl` points relative resolution (the RPC dump) back at
+ * the hub's own meta, so a frame SPA that fetched its per-frame copy (instead
+ * of inheriting the host page's connection) still finds the shared dump.
  */
 async function writeConnectionMetas(
   ctx: DevframeHubContext,
@@ -211,8 +211,11 @@ async function writeConnectionMetas(
   }
   await fs.writeFile(resolve(outDir, DEVFRAME_CONNECTION_META_FILENAME), JSON.stringify(meta, null, 2), 'utf-8')
   const frameMeta: ConnectionMeta = { ...meta, baseUrl: joinURL(base, DEVFRAME_CONNECTION_META_FILENAME) }
+  // A frame served its own SPA exactly when it registered a static mount at its
+  // base; only those need a per-frame meta beside the copied SPA.
+  const servedBases = new Set(ctx.views.buildStaticDirs.map(dir => dir.baseUrl))
   for (const frame of ctx.frames) {
-    if (!frame.hasClientAssets)
+    if (!servedBases.has(frame.base))
       continue
     const target = resolve(resolveOutPath(frame.base), DEVFRAME_CONNECTION_META_FILENAME)
     await fs.mkdir(dirname(target), { recursive: true })

packages/hub/src/node/context.ts

@@ -89,8 +89,7 @@ declare module 'devframe/types' {
  * A devframe mounted into a hub context, recorded as it is installed
  * (whether through `initHub({ devframes })`, `buildHub`, or `ctx.install`).
  * Enumerable via {@link DevframeHubContext.frames} so a host that mounted the
- * context itself can still discover what to advertise in `__index.json` and
- * where to write each frame's connection meta.
+ * context itself can still discover what to advertise in `__index.json`.
  */
 export interface HubMountedFrame {
   /** Dock id the devframe mounted under (disambiguated for duplicates). */
@@ -99,12 +98,6 @@ export interface HubMountedFrame {
   base: string
   /** Human title (the definition's `name`). */
   title: string
-  /**
-   * Whether the devframe served client assets at {@link HubMountedFrame.base}.
-   * A frame with its own SPA gets a per-frame `__connection.json` in a static
-   * build (pointing back at the hub's shared meta); one without does not.
-   */
-  hasClientAssets: boolean
 }
 
 /**

packages/hub/src/node/install-devframe.ts

@@ -94,10 +94,10 @@ async function serveDevframeAssets(
   d: DevframeDefinition,
   id: string,
   base: string,
-): Promise<boolean> {
+): Promise<void> {
   const clientAssets = resolveClientAssets(d)
   if (!clientAssets)
-    return false
+    return
   // Serve the hub's connection meta under the devframe's base so its SPA
   // discovers the RPC/WS endpoint via `connectDevframe()`'s relative
   // `./__connection.json` fetch (rather than inheriting cross-origin from a
@@ -110,7 +110,6 @@ async function serveDevframeAssets(
   // Resolve the plugin's assets against *its* dependency graph: pass the
   // devframe's own `importMetaUrl` as the default `resolveFrom`.
   ctx.views.hostStatic(base, typeof clientAssets === 'string' ? resolve(clientAssets) : clientAssets, d.importMetaUrl)
-  return true
 }
 
 /**
@@ -159,9 +158,9 @@ export async function prepareDevframe(
   if (clientScript)
     dockDefaults.clientScript = clientScript
 
-  const hasClientAssets = await serveDevframeAssets(ctx, d, id, base)
+  await serveDevframeAssets(ctx, d, id, base)
 
-  ;(ctx.frames as HubMountedFrame[]).push({ id, base, title: d.name, hasClientAssets })
+  ;(ctx.frames as HubMountedFrame[]).push({ id, base, title: d.name })
 
   ctx.docks.register({
     id,