From b879e6ab5f0485aa7c11123f1031aac2b32833ac Mon Sep 17 00:00:00 2001 From: AbhishekA1509 Date: Fri, 27 Mar 2026 14:47:48 +0530 Subject: [PATCH 1/2] feat: add loading state for app filters and update getRows logic --- src/components/app/list/DevtronAppListContainer.tsx | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/components/app/list/DevtronAppListContainer.tsx b/src/components/app/list/DevtronAppListContainer.tsx index 7de430f24b..1cafb920b0 100644 --- a/src/components/app/list/DevtronAppListContainer.tsx +++ b/src/components/app/list/DevtronAppListContainer.tsx @@ -126,6 +126,7 @@ const DevtronAppList = ({ clearAllFilters, isArgoInstalled, setAppCount, + appFiltersResponseLoading, }: DevtronAppListProps) => { const [noRows, setNoRows] = useState(false) @@ -152,6 +153,13 @@ const DevtronAppList = ({ const getRows = useCallback( async (_, signal) => { + if (appFiltersResponseLoading) { + return { + rows: [], + totalRows: 0, + } + } + updateDataSyncing(true) const data = await getAppList(getDevtronAppListPayload(filterConfig, environmentList, namespaceList), { signal, @@ -181,7 +189,7 @@ const DevtronAppList = ({ totalRows: totalCount, } }, - [syncListData, filterConfig], + [syncListData, filterConfig, appFiltersResponseLoading], ) const onClearFilters = () => { @@ -209,6 +217,7 @@ const DevtronAppList = ({ id="table__devtron-app-list" getRows={getRows} + loading={appFiltersResponseLoading} paginationVariant={PaginationEnum.PAGINATED} filtersVariant={FiltersTypeEnum.URL} columns={columns} From 48fe6f76a73969a23f0a5fd875ae62b677801a68 Mon Sep 17 00:00:00 2001 From: AbhishekA1509 Date: Fri, 27 Mar 2026 15:41:15 +0530 Subject: [PATCH 2/2] fix: update devtron-fe-common-lib to version 1.23.4 and adjust imports in NameCellComponent --- package.json | 2 +- src/components/app/list/NameCellComponent.tsx | 9 +++++++-- yarn.lock | 10 +++++----- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index e41666b00b..2da04a40cb 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "private": true, "homepage": "/dashboard", "dependencies": { - "@devtron-labs/devtron-fe-common-lib": "1.23.3", + "@devtron-labs/devtron-fe-common-lib": "1.23.4", "@esbuild-plugins/node-globals-polyfill": "0.2.3", "@rjsf/core": "^5.13.3", "@rjsf/utils": "^5.13.3", diff --git a/src/components/app/list/NameCellComponent.tsx b/src/components/app/list/NameCellComponent.tsx index 24eb8a3d94..3a105d9135 100644 --- a/src/components/app/list/NameCellComponent.tsx +++ b/src/components/app/list/NameCellComponent.tsx @@ -1,3 +1,4 @@ +import { Link } from 'react-router-dom' import DOMPurify from 'dompurify' import { @@ -5,8 +6,10 @@ import { FiltersTypeEnum, highlightSearchText, statusColor, + stopPropagation, TableCellComponentProps, Tooltip, + URLS, } from '@devtron-labs/devtron-fe-common-lib' import { App, Environment, TableAdditionalPropsType } from './types' @@ -31,14 +34,16 @@ export const NameCellComponent = ({ const app = data as App - const { name } = app + const { name, id } = app return (
{/* eslint-disable-next-line jsx-a11y/control-has-associated-label */} -