fix: atlan-poc-internal-app-flux-listing#6969
Open
vivekanandan-devtron wants to merge 1 commit into
Open
Conversation
- The deployed app being constructed in a wrong manner meant that apps deployed through Devtron were also getting listed as external app - Use `appName+envName` instead of `appName+namaspace` - Use the already existing util method to construct the deployed app name instead of building the string inline
vivekanandan-devtron
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
• While constructing the map for helm apps, we are building the deploymentAppVariable inline as seen in line 142, which is a combination of appName + namespace.
• This name has to map with deployedApp.Name as seen in line 175. Only then the value will be excluded.
• I can also see a BuildDeployedAppName in DeploymentUtil.go which consists of a combination of appName + environmentName.
• The key is getting constructed in a wrong fashion which is leading to this bug.
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito