[lldb] Implement GetBitSize for builtin types in D TypeSystem

Author: ljmf00

lldb/source/Plugins/TypeSystem/D/DType.cpp

@@ -124,3 +124,61 @@ lldb::BasicType DType::GetBasicType() const {
     return lldb::eBasicTypeOther;
   }
 }
+
+static uint64_t GetRealBitSize(llvm::Triple &target_triple) {
+  if (target_triple.isX86() && target_triple.isArch64Bit())
+    // Assume x87 support: x87 FPU register size
+    return 80;
+
+  // at least size of a double type kind
+  return 64;
+}
+
+llvm::Optional<uint64_t> DType::GetBitSize(llvm::Triple &target_triple) const {
+  return DType::GetBitSize(m_kind, target_triple);
+}
+
+llvm::Optional<uint64_t> DType::GetBitSize(DTypeKind kind, llvm::Triple &target_triple) {
+  switch(kind)
+  {
+    case eDTypeKindPtr:
+      if (target_triple.isArch64Bit())
+        return 64;
+      if (target_triple.isArch32Bit())
+        return 32;
+      if (target_triple.isArch16Bit())
+        return 16;
+
+      // unknown arch bit size
+      return llvm::None;
+    case eDTypeKindBool:
+    case eDTypeKindByte:
+    case eDTypeKindUByte:
+    case eDTypeKindChar:
+      return 8;
+    case eDTypeKindShort:
+    case eDTypeKindUShort:
+    case eDTypeKindWChar:
+      return 16;
+    case eDTypeKindInt:
+    case eDTypeKindUInt:
+    case eDTypeKindDChar:
+    case eDTypeKindFloat:
+      return 32;
+    case eDTypeKindLong:
+    case eDTypeKindULong:
+    case eDTypeKindDouble:
+    case eDTypeKindCFloat:
+      return 64;
+    case eDTypeKindCent:
+    case eDTypeKindUCent:
+    case eDTypeKindCDouble:
+      return 128;
+    case eDTypeKindReal:
+      return GetRealBitSize(target_triple);
+    case eDTypeKindCReal:
+      return GetRealBitSize(target_triple) * 2;
+    default:
+      return llvm::None;
+  }
+}

lldb/source/Plugins/TypeSystem/D/DType.h

@@ -11,6 +11,8 @@
 
 #include "lldb/Utility/ConstString.h"
 #include "lldb/lldb-enumerations.h"
+#include "llvm/ADT/APInt.h"
+#include "llvm/ADT/Triple.h"
 
 enum DTypeKind : uint8_t {
   eDTypeKindInvalid = 0,
@@ -61,6 +63,9 @@ class DType {
   lldb::Encoding GetEncoding(uint64_t &count) const;
   lldb::BasicType GetBasicType() const;
 
+  static llvm::Optional<uint64_t> GetBitSize(DTypeKind kind, llvm::Triple &target_triple);
+  llvm::Optional<uint64_t> GetBitSize(llvm::Triple &target_triple) const;
+
 private:
   DTypeKind m_kind;
   ConstString m_name;

lldb/source/Plugins/TypeSystem/D/TypeSystemD.cpp

@@ -300,7 +300,10 @@ CompilerType TypeSystemD::GetBasicTypeFromAST(lldb::BasicType basic_type) {
 llvm::Optional<uint64_t>
 TypeSystemD::GetBitSize(lldb::opaque_compiler_type_t type,
                         ExecutionContextScope *exe_scope) {
-  return llvm::None;
+  if(!GetCompleteType(type))
+    return llvm::None;
+
+  return static_cast<DType*>(type)->GetBitSize(m_target_triple);
 }
 
 lldb::Encoding TypeSystemD::GetEncoding(lldb::opaque_compiler_type_t type,