Fix compiler warnings (#8098)

Author: StephenCWills

Source/control.cpp

@@ -523,9 +523,6 @@ void PrintFloatingInfo(const Surface &out)
 
 	int spriteH = GetHoverSpriteHeight();
 	int anchorY = floatingInfoBox.position.y;
-	int boxH = floatingInfoBox.size.height;
-	int yAbove = anchorY - spriteH - boxH - vPadding;
-	int yBelow = anchorY + verticalSpacing / 2 + vPadding;
 
 	// Prevent the floating info box from going off-screen vertically
 	floatingInfoBox.position.y = ClampAboveOrBelow(anchorY, spriteH, floatingInfoBox.size.height, vPadding, verticalSpacing);

Source/panels/partypanel.cpp

@@ -120,6 +120,8 @@ PartySpriteOffset GetClassSpriteOffset(HeroClass hClass)
 	case HeroClass::Barbarian:
 		hClass = HeroClass::Warrior;
 		break;
+	default:
+		break;
 	}
 
 	return ClassSpriteOffsets[static_cast<size_t>(hClass)];
@@ -230,7 +232,7 @@ void DrawPartyMemberInfoPanel(const Surface &out)
 		    playerPortraitSprite,
 		    portraitPos);
 
-		if ((player.getId() + 1) < (*PlayerTags).numSprites()) {
+		if ((player.getId() + 1U) < (*PlayerTags).numSprites()) {
 			// Draw the player tag
 			int tagWidth = (*PlayerTags)[player.getId() + 1].width();
 			RenderClxSprite(
@@ -292,9 +294,9 @@ void DrawPartyMemberInfoPanel(const Surface &out)
 
 bool DidRightClickPartyPortrait()
 {
-	for (int i = 0; i < sizeof(PortraitFrameRects) / sizeof(PortraitFrameRects[0]); i++) {
+	for (size_t i = 0; i < sizeof(PortraitFrameRects) / sizeof(PortraitFrameRects[0]); i++) {
 		if (PortraitFrameRects[i].contains(MousePosition)) {
-			RightClickedPortraitIndex = i;
+			RightClickedPortraitIndex = static_cast<int>(i);
 			InspectingFromPartyPanel = true;
 			return true;
 		}

Source/player.cpp

@@ -2057,7 +2057,6 @@ ClxSprite GetPlayerPortraitSprite(Player &player)
 		szCel = "as";
 
 	player_graphic graphic = player_graphic::Stand;
-	int spriteIndex = 0;
 	if (player._pHitPoints <= 0) {
 		if (animWeaponId == PlayerWeaponGraphic::Unarmed) {
 			szCel = "dt";