test(stories): add confirm-exit story for KillModal - #200
Merged
Conversation
The confirm exit animation (kill-overlay-confirm + kill-letter-flash) had no isolated story, so it lacked Chromatic visual-regression coverage. Mirrors the existing Shaking story for the shake exit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
83219e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96b57973.mouseterm.pages.dev |
| Branch Preview URL: | https://test-kill-modal-confirm-stor.mouseterm.pages.dev |
Collaborator
Author
|
CI is green on all functional checks (Build & Test, Standalone Smoketest, Visual Regression Tests, review, Storybook Publish — 153 stories including the new The one non-passing check, UI Tests (Chromatic), is pending on "1 change must be accepted as baseline" — that's the expected outcome here: the new story introduces a fresh snapshot (the confirm-exit visual state), so it needs a maintainer to accept it as the baseline. Nothing is broken; that acceptance is the point of the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the nightly code-quality survey of
lib/src/stories/KillModal.stories.tsx.KillConfirmModalhas two distinct exit-animation states driven by theexitprop (KillExit = 'shake' | 'confirm'):'shake'addsmotion-safe:animate-shake-x, while'confirm'applieskill-overlay-confirmto the overlay andkill-letter-flashto the confirm letter — a separate visual path. Only theshakevariant had a story (Shaking); theconfirmanimation had no isolated story and so no Chromatic visual-regression coverage.This adds a
Confirmingstory, symmetric with the existingShakingstory, so the confirm-exit visuals are captured by Storybook/Chromatic.Docs-adjacent, no runtime behavior change — no code path is modified, so a functional regression test doesn't apply; the story itself is the coverage.