{WIP} Write (some of the) command line options to a configuration file. #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri
force-pushed
the
feature/config-file
branch
from
72f86b6 to
9b0e098
Compare
This allows to later review how the command was run, and more importantly editing the configuration file (via new commands, not implemented yet) and signal the already running pgcopydb to dynamically apply new settings.
Those commands only work when the config.ini file can be found on-disk, which is to say when a pgcopydb command has been started already. The commands allow to review and edit the current settings being used. At the moment editing the values still has no impact on the running processes.
The configuration is written to file and can be edited with the new command pgcopydb config set; now this command also signals the running process with SIGHUP and the config file can be read and applied on-the-fly.
dimitri
force-pushed
the
feature/config-file
branch
from
9b0e098 to
5942b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to later review how the command was run, and more importantly editing the configuration file (via new commands, not implemented yet) and signal the already running pgcopydb to dynamically apply new settings.
See #224