fix: Image plugin linked to deleted filer.Image object. (#59)

Author: marksweb

CHANGELOG.rst

@@ -8,6 +8,7 @@ Unreleased
 * Fix dark mode for select2 widget
 * Fix lint errors in scss files
 * removed forms app
+* Fix for ``Image`` plugin where the associated ``filer.Image`` has been deleted.
 
 0.9.4
 =====

djangocms_frontend/contrib/image/models.py

@@ -38,6 +38,9 @@ def get_size(self, width=None, height=None):
             if self.rel_image:
                 width = self.rel_image.width
                 height = self.rel_image.height
+            else:
+                width = 0
+                height = 0
         else:
             # If no information is available on the image size whatsoever,
             # make it 640px wide and use PICTURE_RATIO
@@ -83,19 +86,26 @@ def img_srcset_data(self):
             return None
 
         srcset = []
-        thumbnailer = get_thumbnailer(self.rel_image)
-        picture_options = self.get_size(self.width, self.height)
-        picture_width = picture_options["size"][0]
-        thumbnail_options = {"crop": picture_options["crop"]}
-        breakpoints = getattr(
-            settings,
-            "DJANGOCMS_PICTURE_RESPONSIVE_IMAGES_VIEWPORT_BREAKPOINTS",
-            [576, 768, 992],
-        )
 
-        for size in filter(lambda x: x < picture_width, breakpoints):
-            thumbnail_options["size"] = (size, size)
-            srcset.append((int(size), thumbnailer.get_thumbnail(thumbnail_options)))
+        try:
+            thumbnailer = get_thumbnailer(self.rel_image)
+
+            picture_options = self.get_size(self.width, self.height)
+            picture_width = picture_options["size"][0]
+            thumbnail_options = {"crop": picture_options["crop"]}
+            breakpoints = getattr(
+                settings,
+                "DJANGOCMS_PICTURE_RESPONSIVE_IMAGES_VIEWPORT_BREAKPOINTS",
+                [576, 768, 992],
+            )
+
+            for size in filter(lambda x: x < picture_width, breakpoints):
+                thumbnail_options["size"] = (size, size)
+                srcset.append((int(size), thumbnailer.get_thumbnail(thumbnail_options)))
+        except ValueError:
+            # get_thumbnailer() raises this if it can't establish a `relative_name`.
+            # This may mean that the filer image has been deleted
+            pass
 
         return srcset
 
@@ -127,8 +137,14 @@ def img_src(self):
             else (),
         }
 
-        thumbnailer = get_thumbnailer(self.rel_image)
-        return thumbnailer.get_thumbnail(thumbnail_options).url
+        try:
+            thumbnailer = get_thumbnailer(self.rel_image)
+            url = thumbnailer.get_thumbnail(thumbnail_options).url
+        except ValueError:
+            # get_thumbnailer() raises this if it can't establish a `relative_name`.
+            # This may mean that the filer image has been deleted
+            url = ''
+        return url
 
     def get_short_description(self):
         if self.external_picture: