Merge pull request #7186 from morozov/deprecate-create-namespace

Deprecate creation of empty namespaces

Author: morozov

UPGRADE.md

@@ -8,6 +8,12 @@ awareness about deprecated code.
 
 # Upgrade to 4.4
 
+## Deprecated `Schema::createNamespace()` and the `$namespaces` constructor parameter
+
+The `Schema::createNamespace()` method and the `$namespaces` constructor parameter have been deprecated. The schema
+automatically derives namespace names from the names of its tables and sequences. Creating empty namespaces is
+deprecated.
+
 ## Deprecated `TableDiff::getDroppedForeignKeys()`
 
 The `TableDiff::getDroppedForeignKeys()` method has been deprecated. Use

src/Schema/Schema.php

@@ -89,6 +89,14 @@ public function __construct(
         ?SchemaConfig $schemaConfig = null,
         array $namespaces = [],
     ) {
+        if (count($namespaces) > 0) {
+            Deprecation::triggerIfCalledFromOutside(
+                'doctrine/dbal',
+                'https://github.com/doctrine/dbal/pull/7186',
+                'Passing the $namespaces argument to the Schema constructor is deprecated.',
+            );
+        }
+
         $schemaConfig ??= new SchemaConfig();
 
         $this->_schemaConfig = $schemaConfig;
@@ -352,10 +360,21 @@ public function getSequences(): array
     /**
      * Creates a new namespace.
      *
+     * @deprecated The schema automatically derives namespaces from the names of its tables and sequences.
+     *             Creating empty namespaces is deprecated.
+     *
      * @return $this
      */
     public function createNamespace(string $name): self
     {
+        Deprecation::triggerIfCalledFromOutside(
+            'doctrine/dbal',
+            'https://github.com/doctrine/dbal/pull/7186',
+            '%s is deprecated. The schema automatically derives namespaces from the names of its tables and'
+                . ' sequences. Creating empty namespaces is deprecated.',
+            __METHOD__,
+        );
+
         $unquotedName = strtolower($this->getUnquotedAssetName($name));
 
         if (isset($this->namespaces[$unquotedName])) {