App crash and 500 error when using authorizeFromControllerV2

[gstanzione]

Problem Description

When using SwiftyDropbox version 10.2.3 in an iOS app (minimum deployment target: iOS 13.0, UIKit, Swift), I encountered issues with DropboxClientsManager.authorizeFromControllerV2 regarding the includeGrantedScopes parameter in scopeRequest.

Reproduction Steps

Case 1: includeGrantedScopes: true

DropboxClientsManager.authorizeFromControllerV2(
    UIApplication.shared,
    controller: viewController,
    loadingStatusDelegate: loadingDelegate,
    openURL: { url in
        UIApplication.shared.open(url, options: [:], completionHandler: nil)
    },
    scopeRequest: .init(scopeType: .user, scopes: [], includeGrantedScopes: true)
)

This configuration results in a web error:

Case 2: includeGrantedScopes: false

DropboxClientsManager.authorizeFromControllerV2(
    UIApplication.shared,
    controller: viewController,
    loadingStatusDelegate: loadingDelegate,
    openURL: { url in
        UIApplication.shared.open(url, options: [:], completionHandler: nil)
    },
    scopeRequest: .init(scopeType: .user, scopes: [], includeGrantedScopes: false)
)

This causes a crash with the following error:

*** Terminating app due to uncaught exception 'NSUnknownKeyException', reason: '[<SwiftyDropbox.LoadingViewController 0x15607a400> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key loadingImageView.'

Environment

• SwiftyDropbox version: 10.2.3
• iOS version: 13.0+
• Swift: 5.0
• UIKit used

Expected Behavior

• Both usages should not cause server errors or application crashes.

Actual Behavior

• Usage with includeGrantedScopes: true results in a 500 error (see screenshot attached).
• Usage with includeGrantedScopes: false crashes the app due to an NSUnknownKeyException related to loadingImageView in LoadingViewController.

Additional Notes

• The issues are consistently reproducible with the steps above.
• Please advise if there are recommended workarounds or if additional debug info is needed.
• if I use the deprecated APIs everything works fine:

DropboxClientsManager.authorizeFromController(
     UIApplication.shared, controller: viewController
) { url in
     UIApplication.shared.open(url, options: [:], completionHandler: nil)
}

[alyx-db]

Hi @gstanzione,

Thanks for the report! We're investigating this API issue. We'll follow up here once we have an update.

[jboulter11]

I can't reproduce your first scenario getting a 500, but I do get a Bad Request response, presumably providing true without previously granted scopes and nothing in the list is a bad request. When I add a scopes list it starts working like I'd expect. If you can provide more info about the 500 you're seeing, like a request id header, I can look into the 500.

For the false scenario, that's a bug. I am assuming, based off previous reports, that you have a LoadingViewController in your project, and it's conflicting with the LoadingViewController in our code. I'm renaming it in #451 which should fix that issue. You can workaround it for now by renaming that controller in your project, but our fix should be available pretty soon. If you don't have a LoadingViewController, presumably with a loadingImageView in your project, let me know.

[gstanzione]

Hi @jboulter11,

I don't have a UIViewController called LoadingViewController, but I had a UIView custom class (and a xib) called LoadingView that I have now renamed differently, and the crash doesn't happen anymore. So the false scenario seems to be solved.

Now:

• if I pass to includeGrantedScopes the value true (regardless of what I pass to scopes)
• or if I pass to includeGrantedScopes the value false and to scopes I pass (for example) ["account_info.read"]

I get the error:

Instead, if I pass to includeGrantedScopes the value false, and to scopes I pass an empty array, everything works correctly, so I'll do it like this.

[jboulter11]

Might have something to do with which scopes you've chosen in the app console for your application.

You can see more documentation on the API being called here: https://www.dropbox.com/developers/documentation/http/documentation (search for oauth2/authorize)
And the oauth guide here: https://www.dropbox.com/developers/oauth-guide

That LoadingView xib definitely is the conflict then, thank you for confirming. We'll ship our fix to resolve that conflict on our end with release 10.2.4, hopefully today.

Glad you're unblocked, if you need anything else let us know.