Skip to content

SVS anonymize outfile argument ignored if infolog is False #4

@fiendish

Description

@fiendish

Outfile assignment only happens if infolog is True, but they should/could be entirely independent of each other.

if infolog:
root, ext = os.path.splitext(self._filename)
if outfile is None:
outfile = root + '_anonym.svs'
shutil.copyfile(self._filename, outfile)
filename = outfile
infos = dict()
else:
filename = self._filename

The above snippet is from the SVS anonymizer, but the same pattern appears to be repeated in the others as well.

I think it would make more sense for the outfile assignment to work regardless of whether you want the additional info file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions