Add rule no-unnecessary-combination (#43)

* Add test cases for no-unnecessary-combination

* Add basic implementation of no-unnecessary-combination

* Export no-unnecessary-combination properly

* Add docs of no-unnecessary-combination

Author: igorkamyshev

README.md

@@ -49,6 +49,7 @@ To configure individual rules:
 - [effector/no-ambiguity-target](rules/no-ambiguity-target/no-ambiguity-target.md)
 - [effector/prefer-sample-over-forward-with-mapping](rules/prefer-sample-over-forward-with-mapping/prefer-sample-over-forward-with-mapping.md)
 - [effector/no-watch](rules/no-watch/no-watch.md)
+- [effector/no-unnecessary-combination](rules/no-unnecessary-combination/no-unnecessary-combination.md)
 
 ## Maintenance
 

config/recommended.js

@@ -8,5 +8,6 @@ module.exports = {
     "effector/prefer-sample-over-forward-with-mapping": "warn",
     "effector/no-ambiguity-target": "warn",
     "effector/no-watch": "warn",
+    "effector/no-unnecessary-combination": "warn",
   },
 };

index.js

@@ -8,6 +8,7 @@ module.exports = {
     "no-useless-methods": require("./rules/no-useless-methods/no-useless-methods"),
     "no-ambiguity-target": require("./rules/no-ambiguity-target/no-ambiguity-target"),
     "no-watch": require("./rules/no-watch/no-watch"),
+    "no-unnecessary-combination": require("./rules/no-unnecessary-combination/no-unnecessary-combination"),
   },
   configs: {
     recommended: require("./config/recommended"),

rules/no-unnecessary-combination/examples/correct.ts

@@ -0,0 +1,20 @@
+import { createEvent, createStore, forward, guard, sample } from "effector";
+
+const event1 = createEvent();
+const event2 = createEvent();
+const $store1 = createStore(null);
+const $store2 = createStore(null);
+
+sample({ clock: [event1, event2], source: [$store1, $store2] });
+
+sample({ clock: event1, source: [$store1, $store2] });
+
+sample({ clock: event1, source: { a: $store1, b: $store2 } });
+
+guard({ clock: [event1, event2], source: $store1, filter: Boolean });
+
+guard({ clock: event1, source: { a: $store1 }, filter: Boolean });
+
+const otherEvent = createEvent();
+
+forward({ from: [event1, event2], to: otherEvent });

rules/no-unnecessary-combination/examples/unnecessary-combine-in-clock-guard.ts

@@ -0,0 +1,6 @@
+import { combine, createEvent, createStore, guard, merge } from "effector";
+
+const $store1 = createStore(null);
+const $store2 = createStore(null);
+
+guard({ clock: combine($store1, $store2), filter: Boolean });

rules/no-unnecessary-combination/examples/unnecessary-combine-in-clock-sample.ts

@@ -0,0 +1,6 @@
+import { combine, createStore, sample } from "effector";
+
+const $store1 = createStore(null);
+const $store2 = createStore(null);
+
+sample({ clock: combine($store1, $store2) });

rules/no-unnecessary-combination/examples/unnecessary-combine-in-from-forward.ts

@@ -0,0 +1,8 @@
+import { combine, createEvent, createStore, forward } from "effector";
+
+const $store1 = createStore(null);
+const $store2 = createStore(null);
+
+const target = createEvent();
+
+forward({ from: combine($store1, $store2), to: target });

rules/no-unnecessary-combination/examples/unnecessary-combine-in-source-guard.ts

@@ -0,0 +1,6 @@
+import { combine, createEvent, createStore, guard, merge } from "effector";
+
+const $store1 = createStore(null);
+const $store2 = createStore(null);
+
+guard({ source: combine($store1, $store2), filter: Boolean });

rules/no-unnecessary-combination/examples/unnecessary-combine-in-source-sample.ts

@@ -0,0 +1,6 @@
+import { combine, createStore, sample } from "effector";
+
+const $store1 = createStore(null);
+const $store2 = createStore(null);
+
+sample({ source: combine($store1, $store2) });

rules/no-unnecessary-combination/examples/unnecessary-merge-in-clock-guard.ts

@@ -0,0 +1,6 @@
+import { createEvent, guard, merge } from "effector";
+
+const event1 = createEvent();
+const event2 = createEvent();
+
+guard({ clock: merge([event1, event2]), filter: Boolean });