Fix false-positive in no-duplicate-on (#86)

* Add test case for bug

* fix bug

Author: igorkamyshev

rules/no-duplicate-on/examples/correct-with-nesting.ts

@@ -0,0 +1,18 @@
+// Examples were found in production code-base with false-poitive detection on 0.5.2
+// https://github.com/effector/eslint-plugin/issues/85
+
+import { createEvent, createStore } from "effector";
+
+const $first = createStore("");
+const $second = createStore("");
+
+const change = createEvent();
+
+const service = {
+  inputs: { $first, $second },
+};
+
+service.inputs.$first.on(change, () => "HI");
+service.inputs.$second.on(change, () => "BYE");
+
+export { service };

rules/no-duplicate-on/no-duplicate-on.js

@@ -1,5 +1,8 @@
 const { createLinkToRule } = require("../../utils/create-link-to-rule");
 const { getNestedObjectName } = require("../../utils/get-nested-object-name");
+const {
+  traverseNestedObjectNode,
+} = require("../../utils/traverse-nested-object-node");
 const { is } = require("../../utils/is");
 
 module.exports = {
@@ -56,7 +59,9 @@ module.exports = {
 
     return {
       'CallExpression[callee.property.name="on"]'(node) {
-        const storeObject = getNestedCallee(node) ?? getAssignedVariable(node);
+        const storeObject = traverseNestedObjectNode(
+          getNestedCallee(node) ?? getAssignedVariable(node)
+        );
         const storeName = getStoreName(storeObject);
 
         if (!is.store({ context, node: storeObject })) {

rules/no-duplicate-on/no-duplicate-on.ts.test.js

@@ -21,7 +21,11 @@ const readExampleForTheRule = (name) => ({
 });
 
 ruleTester.run("effector/no-duplicate-on.ts.test", rule, {
-  valid: ["correct.ts", "correct-with-scopes.ts"].map(readExampleForTheRule),
+  valid: [
+    "correct.ts",
+    "correct-with-scopes.ts",
+    "correct-with-nesting.ts",
+  ].map(readExampleForTheRule),
   invalid: ["incorrect-with-invalid-naming.ts"]
     .map(readExampleForTheRule)
     .map((example) => ({