Allow creating a Store in a property in enforce-store-naming-convention (#159)

fix(enforce-store-naming-convention): support createStore in property

Author: kireevmp

rules/enforce-store-naming-convention/enforce-store-naming-convention.js

@@ -94,7 +94,7 @@ module.exports = {
           }
 
           const parentNode = traverseParentByType(node, "VariableDeclarator", {
-            stopOnTypes: ["Program", "BlockStatement"],
+            stopOnTypes: ["Program", "BlockStatement", "Property"],
           });
 
           const resultSavedInVariable =
@@ -153,7 +153,7 @@ module.exports = {
           STORE_IN_DOMAIN_CREATION_METHODS.includes(node.callee?.property?.name)
         ) {
           const parentNode = traverseParentByType(node, "VariableDeclarator", {
-            stopOnTypes: ["Program", "BlockStatement"],
+            stopOnTypes: ["Program", "BlockStatement", "Property"],
           });
 
           const resultSavedInVariable =

rules/enforce-store-naming-convention/prefix/enforce-store-naming-convention-prefix.test.js

@@ -21,6 +21,9 @@ ruleTester.run("effector/enforce-store-naming-convention-prefix.test", rule, {
     "correct-examples-issue-23.js",
     "correct-examples-issue-128.js",
     "correct-examples-issue-136.js",
+    "correct-examples-issue-150.js",
+    "correct-examples-issue-158.js",
+    "correct-store-naming-property-domain.js",
     "correct-store-naming-with-handlers.js",
     "correct-store-naming-in-domain-with-handlers.js",
     "correct-factory.js",

rules/enforce-store-naming-convention/prefix/examples/correct-examples-issue-150.js

@@ -0,0 +1,22 @@
+import { attach, combine, createStore, createEffect } from "effector";
+
+const testFx = attach({
+  source: createStore(0),
+  effect: createEffect(),
+});
+
+const combineFx = attach({
+  source: {
+    value: combine(),
+  },
+  effect: createEffect(),
+});
+
+const createStoreFx = attach({
+  source: {
+    value: createStore(0),
+  },
+  effect: createEffect(),
+});
+
+export { testFx, combineFx, createStoreFx };

rules/enforce-store-naming-convention/prefix/examples/correct-examples-issue-158.js

@@ -0,0 +1,11 @@
+import { createStore } from "effector";
+
+const arrow = ({ store = createStore(0) }) => {
+  return { store };
+};
+
+function declaration({ store = createStore(1) }) {
+  return { store };
+}
+
+export { arrow, declaration };

rules/enforce-store-naming-convention/prefix/examples/correct-store-naming-property-domain.js

@@ -0,0 +1,17 @@
+import { createDomain } from "effector";
+import { attach, createEffect } from "effector";
+
+const domain = createDomain();
+const effect = createEffect();
+
+const storeFx = attach({
+  source: domain.store(0),
+  effect,
+});
+
+const createStoreFx = attach({
+  source: domain.createStore(0),
+  effect,
+});
+
+export { storeFx, createDomain };