Fix debug patronum (#126)

Fix false positives from the rule

Add test case when there are no import

Fix delete without formatting loss when using semicolon

Author: raidenmiro

rules/no-patronum-debug/no-patronum-debug.js

@@ -31,10 +31,13 @@ module.exports = {
         });
       },
       CallExpression(node) {
-        const currentMethodName = node.callee?.name ?? node.callee?.object.name;
+        const currentMethod = node?.callee?.name ?? node?.callee?.object.name;
         const importedDebugFromPatronum = importedFromPatronum.get("debug");
 
-        if (currentMethodName !== importedDebugFromPatronum) {
+        if (
+          !importedDebugFromPatronum ||
+          currentMethod !== importedDebugFromPatronum
+        ) {
           return;
         }
 
@@ -71,7 +74,12 @@ function* removeDebugFromPatronum({
   const startToken = sourceCode.getTokenBefore(node);
 
   // remove line with debug
-  yield fixer.removeRange([startToken.range[1], node.range[1] + 1]);
+  yield fixer.removeRange([startToken.range[1], node.range[1]]);
+  const semi = sourceCode.getTokenBefore(node, {
+    filter: (token) => token.value === ";",
+  });
+
+  if (semi) yield fixer.remove(semi);
 
   const importDebugNode = importNodes.get(targetMethod);
 
@@ -81,12 +89,13 @@ function* removeDebugFromPatronum({
 
   // remove import with debug
   const importParentNode = importDebugNode.parent;
+  const amountImportFromPatronum = importParentNode.specifiers.length;
 
   /**
    * import { debug } from 'patronum'
    * import { debug } from 'patronum/debug'
    */
-  if (importParentNode.specifiers.length === 1) {
+  if (amountImportFromPatronum === 1) {
     yield fixer.removeRange([
       importParentNode.range[0],
       importParentNode.range[1] + 1,
@@ -95,9 +104,7 @@ function* removeDebugFromPatronum({
     return null;
   }
 
-  const amountImportFromPatronum = importParentNode.specifiers.length;
   const importLast = importParentNode.specifiers[amountImportFromPatronum - 1];
-
   const filterTokenComma = { filter: (token) => token.value === "," };
 
   /**

rules/no-patronum-debug/no-patronum-debug.test.js

@@ -26,6 +26,9 @@ debug(store);
     `
 import { debug } from 'patronum/debug'
 sample({ clock: tick, target: runFx })
+`,
+    `
+const $store = createStore(false).on(open, () => true)
 `,
   ].map((code) => ({ code })),
 
@@ -80,7 +83,7 @@ const buttonClicked = createEvent();
     {
       code: `
 import { delay, debug, condition } from 'patronum';
-const $store = createEffect(() => 'effectFx');
+const effectFx = createEffect(() => 'effectFx');
 debug({ trace: true }, $store);
 `,
       errors: [
@@ -92,7 +95,7 @@ debug({ trace: true }, $store);
               messageId: "removePatronumDebug",
               output: `
 import { delay, condition } from 'patronum';
-const $store = createEffect(() => 'effectFx');
+const effectFx = createEffect(() => 'effectFx');
 `,
             },
           ],
@@ -214,5 +217,47 @@ const event = createEvent()`,
         },
       ],
     },
+    {
+      code: `
+import { condition, debug, delay } from 'patronum'
+
+const $store = createStore(false)
+
+const createTest = () => {
+  const state = {
+    equal(a, b) {
+      return a === b
+    }
+  }
+  debug($store)
+  return state
+}
+`,
+      errors: [
+        {
+          messageId: "noPatronumDebug",
+          type: "CallExpression",
+          suggestions: [
+            {
+              messageId: "removePatronumDebug",
+              output: `
+import { condition, delay } from 'patronum'
+
+const $store = createStore(false)
+
+const createTest = () => {
+  const state = {
+    equal(a, b) {
+      return a === b
+    }
+  }
+  return state
+}
+`,
+            },
+          ],
+        },
+      ],
+    },
   ],
 });