-
Notifications
You must be signed in to change notification settings - Fork 862
[EuiSuperDatePicker] Papercuts #9239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- improve interaction for QuickSelectOnly - update VRT
💚 Build Succeededcc @acstll |
💚 Build Succeeded
Historycc @acstll |
| css={css` | ||
| /* ensure the input content is visible without being truncated */ | ||
| inline-size: 700px; | ||
| `} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgadewoll the problem was this 😁 — I couldn't find anything breaking after removing this, and I updated the stories (they look a bit more "real"), but I might be missing something — where is/was the input content being truncated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch! Honestly, I can't recall what was the scenario there. But it looks to behave fine in the stories, so it's fine to remove. Ensuring stories showcase expected behavior has higher priority in any case. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 The changes are LGTM.
Tested that the accessible labels are available and confirmed isQuickSelectOnly renders as expected in storybook. EuiQuickSelectPanel is available for export.
Summary
This PR has a small series of changes related to
EuiSuperDatePicker, namely:EuiQuickSelectPanel— this has been left undocumented on purpose, because there's a way to customize quick select panels (92c945e)isQuickSelectOnlyprop in Storybook, where the popover button would still be visible when it shouldn't (b3ea2d5)Resolves https://github.com/elastic/eui-private/issues/472 🔒
Why are we making this change?
To wrap up a series of improvements to
EuiSuperDatePicker, fixing small things that mostly were out of scope in previous PRs.Impact to users
🟢 No impact
QA
EuiQuickSelectPanelis exportedisQuickSelectOnlyprop behaves as expected in StorybookGeneral checklist
Checked in both light and dark modesChecked in both MacOS and Windows high contrast modes(emulate forced colors if you do not have access to a Windows machine.)Checked in mobileChecked in Chrome, Safari, Edge, and FirefoxAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)