Skip to content

Conversation

@acstll
Copy link
Contributor

@acstll acstll commented Nov 25, 2025

Summary

This PR has a small series of changes related to EuiSuperDatePicker, namely:

Resolves https://github.com/elastic/eui-private/issues/472 🔒

Why are we making this change?

To wrap up a series of improvements to EuiSuperDatePicker, fixing small things that mostly were out of scope in previous PRs.

Impact to users

🟢 No impact

QA

  • Verify EuiQuickSelectPanel is exported
  • Check accessibility of text inputs in absolute and relative tabs
  • Double-check isQuickSelectOnly prop behaves as expected in Storybook
  • Verify snippet for Time Window Buttons section in the docs works as expected

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@acstll acstll self-assigned this Nov 25, 2025
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @acstll

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 25, 2025

💚 Build Succeeded

History

cc @acstll

Comment on lines -382 to -385
css={css`
/* ensure the input content is visible without being truncated */
inline-size: 700px;
`}
Copy link
Contributor Author

@acstll acstll Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgadewoll the problem was this 😁 — I couldn't find anything breaking after removing this, and I updated the stories (they look a bit more "real"), but I might be missing something — where is/was the input content being truncated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! Honestly, I can't recall what was the scenario there. But it looks to behave fine in the stories, so it's fine to remove. Ensuring stories showcase expected behavior has higher priority in any case. 👍

@acstll acstll marked this pull request as ready for review November 25, 2025 19:47
@acstll acstll requested a review from a team as a code owner November 25, 2025 19:48
@mgadewoll mgadewoll self-requested a review November 26, 2025 09:37
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 The changes are LGTM.
Tested that the accessible labels are available and confirmed isQuickSelectOnly renders as expected in storybook. EuiQuickSelectPanel is available for export.

@acstll acstll merged commit 02528cc into elastic:main Nov 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants