Skip to content

Conversation

@lresende
Copy link
Member

@lresende lresende commented Jan 2, 2024

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende force-pushed the lresende-lab4 branch 2 times, most recently from a53ad57 to d2f865d Compare January 3, 2024 00:43
@lresende lresende force-pushed the lresende-lab4 branch 2 times, most recently from e0565c5 to b5f443e Compare January 25, 2024 22:38
@karlaspuldaro
Copy link
Member

We need a detailed issue for migration to JupyterLab 4, to keep track of all required steps, this PR could be step one.
In my opinion, it would be best to plan the steps more carefully, so they're better isolated. Changing all dependencies at once can affect everything, and the changes become complex too quickly.

Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
@lresende
Copy link
Member Author

lresende commented Sep 1, 2025

@karlaspuldaro do you want to take another look? I will play with actually testing it in the elyra pipeline editor next...

@lresende
Copy link
Member Author

lresende commented Sep 1, 2025

@caponetto if you have some cycles, please also provide your feedback, ui is not my best area :)

@caponetto
Copy link

@lresende I'll check those changes out asap, but note that I had already worked on a similar thing a while ago 😆

@lresende
Copy link
Member Author

lresende commented Oct 2, 2025

Any concerns here @caponetto ?

@caponetto
Copy link

@lresende I see that GH workflows didn't run correctly for this PR. Could you please take a look at the changes in .github/workflows/build.yaml? See https://github.com/elyra-ai/pipeline-editor/actions/runs/17367046920/workflow

Signed-off-by: Luciano Resende <[email protected]>
@caponetto
Copy link

@lresende I remember I got a green CI in lresende#1
Feel free to put that code into this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants