Support empty string as value of option (#26)

* Support empty string as value of option

* Use isNone instead of isBlank

* Test to validate empty string as value

Author: javve

addon/components/select-light.js

@@ -1,5 +1,5 @@
 import Component from '@glimmer/component';
-import { isPresent } from '@ember/utils';
+import { isNone } from '@ember/utils';
 
 const noop = () => {};
 
@@ -13,9 +13,9 @@ export default class extends Component {
   }
 
   get hasDetailedOptions() {
-    return [ // Returns a boolean if all data is available for a { label: foo, value: bar } style list of options
+    return ![ // Returns a boolean if all data is available for a { label: foo, value: bar } style list of options
       this.args.options?.[0][this.valueKey],
       this.args.options?.[0][this.displayKey],
-    ].every(isPresent);
+    ].some(isNone);
   }
 }

tests/integration/components/select-light-test.js

@@ -161,6 +161,28 @@ module('Integration | Component | select-light', function(hooks) {
 		assert.dom('select option').includesText(options[0].description);
 	});
 
+	test('should render options correctly when value is an empty string', async function(assert) {
+		let options = [
+			{ value: '', label: 'None' },
+			{ value: 'mako', label: 'Mako Shark' },
+		];
+		let value = options[1].value;
+		this.setProperties({
+			options,
+			value,
+		});
+
+		await render(hbs`
+      <SelectLight
+        @options={{this.options}}
+				@value={{this.value}} />`);
+
+    assert.dom('select option').exists({ count: options.length });
+		assert.dom('select option').hasAttribute('value', options[0].value);
+		assert.dom('select option').includesText(options[0].label);
+		assert.dom('select').hasValue(value);
+	});
+
 	test('should fire change when user chooses option, mut with yield', async function(assert) {
 		this.set('myValue', null);