Skip to content

Invalid messages logged to console #281

@robbytx

Description

@robbytx

Upon upgrading to Ember 3.7.x, I found that the JavaScript console had strange messages being logged from this library, like:

Transition #Attempting URL transition to /myroute/123: undefined
Preparing to transition from '' to 'myroute'
0
Transitioned into 'myroute'
0

The 1st, 3rd, and 5th, messages all seem to stem from an incorrect check in the log function at:
https://github.com/tildeio/router.js/blob/master/lib/router/utils.ts#L74

I think if (arguments.length === 2) should be replaced with if (args.length === 2).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions