feat(ratelimit): support ClusterSetting for ratelimit cluster by zirain · Pull Request #9902 · envoyproxy/gateway

zirain · 2026-08-31T08:38:53Z

this's useful if users want to custom the maxRequestsPerConnection for ratelimit_cluster instead of using EnvoyPatchPolicy

~~we may not need this if we agree to allow #9816 without MergeBackend enabled.~~

netlify · 2026-08-31T08:38:59Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`ef06393`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6aa7b02830dd9b00080448e3
😎 Deploy Preview	https://deploy-preview-9902--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5d730073d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-08-31T08:59:45Z

Codecov Report

❌ Patch coverage is 93.75000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.31%. Comparing base (01f026a) to head (ef06393).

Files with missing lines	Patch %	Lines
api/v1alpha1/validation/envoygateway_validate.go	94.28%	4 Missing ⚠️
internal/gatewayapi/globalresources.go	92.85%	1 Missing ⚠️
internal/gatewayapi/runner/runner.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9902      +/-   ##
==========================================
- Coverage   81.31%   81.31%   -0.01%     
==========================================
  Files         264      264              
  Lines       40973    41062      +89     
==========================================
+ Hits        33319    33390      +71     
- Misses       7653     7671      +18     
  Partials        1        1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d3b4593a7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

zhaohuabing · 2026-09-04T09:56:16Z

+	// service, such as circuit breakers, timeouts, health checks, and load balancing.
+	//
+	// +optional
+	BackendSettings *ClusterSettings `json:"backendSettings,omitempty"`


Nit, the combination of BackendSettings and Backend is a bit confusing inside RateLimit.

that's because backend in Ratelimit means the redis backend.
Rename to ClusterSettings, WDYT?

ClusterSettings works for me.

Signed-off-by: zirain <zirain2009@gmail.com>

zirain · 2026-09-10T05:10:22Z

/retest

Signed-off-by: zirain <zirain2009@gmail.com>

arkodg · 2026-09-14T04:18:39Z

 	// +optional
 	Telemetry *RateLimitTelemetry `json:"telemetry,omitempty"`
+
+	// ClusterSettings holds configuration for managing the connection to the rate limit


shouldnt this be BackendSettings similar to Policy counterpart ?

because of #9902 (comment)

zhaohuabing · 2026-09-18T07:09:43Z

@codex review

zirain · 2026-09-20T07:28:20Z

@codex review

zirain requested a review from a team as a code owner August 31, 2026 08:38

chatgpt-codex-connector Bot reviewed Aug 31, 2026

View reviewed changes

Comment thread api/v1alpha1/envoygateway_types.go

Comment thread api/v1alpha1/envoygateway_types.go

Comment thread api/v1alpha1/envoygateway_types.go

zirain force-pushed the ratelimit-clustersettings branch from 1963bcb to 2a0e371 Compare September 1, 2026 05:20

zirain marked this pull request as draft September 2, 2026 03:57

zirain force-pushed the ratelimit-clustersettings branch from 2a0e371 to 8a58c06 Compare September 2, 2026 04:02

zirain marked this pull request as ready for review September 2, 2026 07:43

chatgpt-codex-connector Bot reviewed Sep 2, 2026

View reviewed changes

Comment thread api/v1alpha1/envoygateway_types.go Outdated

Comment thread api/v1alpha1/validation/envoygateway_validate.go

Comment thread internal/gatewayapi/globalresources.go Outdated

zirain force-pushed the ratelimit-clustersettings branch from 803565c to bbd229d Compare September 2, 2026 10:41

zirain added this to the v1.10.0-rc.1 Release milestone Sep 3, 2026

zhaohuabing reviewed Sep 4, 2026

View reviewed changes

Comment thread internal/ir/xds.go Outdated

zhaohuabing reviewed Sep 4, 2026

View reviewed changes

zirain force-pushed the ratelimit-clustersettings branch from acf44fb to 08ba30b Compare September 9, 2026 09:24

zirain added 2 commits September 10, 2026 09:17

feat(ratelimit): support ClusterSetting for ratelimit cluster

5445334

Signed-off-by: zirain <zirain2009@gmail.com>

fix

268861c

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the ratelimit-clustersettings branch from 08ba30b to 268861c Compare September 10, 2026 01:21

zirain added 2 commits September 10, 2026 09:30

rename to clusterSettings

f6fe17f

Signed-off-by: zirain <zirain2009@gmail.com>

Merge branch 'main' into ratelimit-clustersettings

ae190ba

zirain requested a review from zhaohuabing September 10, 2026 02:29

zirain force-pushed the ratelimit-clustersettings branch from ae190ba to e71d046 Compare September 10, 2026 02:53

Merge branch 'main' into ratelimit-clustersettings

33918e7

zirain force-pushed the ratelimit-clustersettings branch from e71d046 to 33918e7 Compare September 11, 2026 00:58

fix e2e

a9b430f

Signed-off-by: zirain <zirain2009@gmail.com>

zhaohuabing requested review from a team and removed request for zhaohuabing September 11, 2026 05:40

Merge branch 'main' into ratelimit-clustersettings

cfe6831

arkodg reviewed Sep 14, 2026

View reviewed changes

Merge branch 'main' into ratelimit-clustersettings

ef06393

zirain requested review from arkodg and zhaohuabing September 20, 2026 07:28

Conversation

zirain commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhaohuabing Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhaohuabing Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

zirain commented Sep 10, 2026

Uh oh!

arkodg Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

zhaohuabing commented Sep 18, 2026

Uh oh!

zirain commented Sep 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zirain commented Aug 31, 2026 •

edited

Loading

netlify Bot commented Aug 31, 2026 •

edited

Loading

codecov Bot commented Aug 31, 2026 •

edited

Loading

zirain Sep 4, 2026 •

edited

Loading