Skip to content

Commit 2709fff

Browse files
committed
fix: warnings
1 parent 93eb803 commit 2709fff

File tree

7 files changed

+23
-23
lines changed

7 files changed

+23
-23
lines changed

crates/erg_common/build.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ fn main() -> std::io::Result<()> {
2727
} else {
2828
true
2929
};
30-
println!("cargo:rustc-env=CASE_SENSITIVE={}", case_sensitive);
30+
println!("cargo:rustc-env=CASE_SENSITIVE={case_sensitive}");
3131
Ok(())
3232
}

crates/erg_compiler/hir.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1982,8 +1982,8 @@ pub enum GuardClause {
19821982
impl NestedDisplay for GuardClause {
19831983
fn fmt_nest(&self, f: &mut std::fmt::Formatter<'_>, _level: usize) -> std::fmt::Result {
19841984
match self {
1985-
GuardClause::Condition(cond) => write!(f, "{}", cond),
1986-
GuardClause::Bind(bind) => write!(f, "{}", bind),
1985+
GuardClause::Condition(cond) => write!(f, "{cond}"),
1986+
GuardClause::Bind(bind) => write!(f, "{bind}"),
19871987
}
19881988
}
19891989
}

crates/erg_compiler/ty/codeobj.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -642,14 +642,14 @@ impl CodeObj {
642642
write!(instrs, "{arg} ({})", self.cellvars[arg]).unwrap();
643643
}
644644
Opcode308::JUMP_ABSOLUTE => {
645-
write!(instrs, "{arg} (to {})", arg).unwrap();
645+
write!(instrs, "{arg} (to {arg})").unwrap();
646646
}
647647
Opcode308::JUMP_FORWARD => {
648648
write!(instrs, "{arg} (to {})", idx + arg + 2).unwrap();
649649
}
650650
// REVIEW: *2?
651651
Opcode308::POP_JUMP_IF_FALSE | Opcode308::POP_JUMP_IF_TRUE => {
652-
write!(instrs, "{arg} (to {})", arg).unwrap();
652+
write!(instrs, "{arg} (to {arg})").unwrap();
653653
}
654654
Opcode308::BINARY_ADD
655655
| Opcode308::BINARY_SUBTRACT
@@ -690,14 +690,14 @@ impl CodeObj {
690690
write!(instrs, "{arg} ({})", self.cellvars[arg]).unwrap();
691691
}
692692
Opcode309::JUMP_ABSOLUTE => {
693-
write!(instrs, "{arg} (to {})", arg).unwrap();
693+
write!(instrs, "{arg} (to {arg})").unwrap();
694694
}
695695
Opcode309::JUMP_FORWARD => {
696696
write!(instrs, "{arg} (to {})", idx + arg + 2).unwrap();
697697
}
698698
// REVIEW: *2?
699699
Opcode309::POP_JUMP_IF_FALSE | Opcode309::POP_JUMP_IF_TRUE => {
700-
write!(instrs, "{arg} (to {})", arg).unwrap();
700+
write!(instrs, "{arg} (to {arg})").unwrap();
701701
}
702702
Opcode309::BINARY_ADD
703703
| Opcode309::BINARY_SUBTRACT

crates/erg_compiler/ty/constructors.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,12 +183,12 @@ pub fn try_v_enum(s: Set<ValueObj>) -> Result<Type, Set<ValueObj>> {
183183
}
184184

185185
pub fn v_enum(s: Set<ValueObj>) -> Type {
186-
try_v_enum(s).unwrap_or_else(|set| panic!("not homogeneous: {}", set))
186+
try_v_enum(s).unwrap_or_else(|set| panic!("not homogeneous: {set}"))
187187
}
188188

189189
pub fn t_enum(s: Set<Type>) -> Type {
190190
try_v_enum(s.into_iter().map(ValueObj::builtin_type).collect())
191-
.unwrap_or_else(|set| panic!("not homogeneous: {}", set))
191+
.unwrap_or_else(|set| panic!("not homogeneous: {set}"))
192192
}
193193

194194
pub fn t_singleton(t: Type) -> Type {

crates/erg_compiler/ty/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ impl LimitedDisplay for SubrType {
451451
}
452452
write!(f, "*")?;
453453
if let Some(name) = var_params.name() {
454-
write!(f, "{}: ", name)?;
454+
write!(f, "{name}: ")?;
455455
}
456456
var_params.typ().limited_fmt(f, limit - 1)?;
457457
}

crates/erg_parser/ast.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2162,19 +2162,19 @@ impl NestedDisplay for Call {
21622162
if i != 0 {
21632163
write!(f, ", ")?;
21642164
}
2165-
write!(f, "{}", arg)?;
2165+
write!(f, "{arg}")?;
21662166
}
21672167
if let Some(rest) = self.args.var_args.as_ref() {
21682168
if !self.args.pos_args().is_empty() {
21692169
write!(f, ", ")?;
21702170
}
2171-
write!(f, "*{}", rest)?;
2171+
write!(f, "*{rest}")?;
21722172
}
21732173
for (i, kw_arg) in self.args.kw_args().iter().enumerate() {
21742174
if i != 0 || !self.args.pos_args().is_empty() || self.args.var_args.is_some() {
21752175
write!(f, ", ")?;
21762176
}
2177-
write!(f, "{}", kw_arg)?;
2177+
write!(f, "{kw_arg}")?;
21782178
}
21792179
write!(f, ")")
21802180
} else {
@@ -3194,7 +3194,7 @@ impl NestedDisplay for ConstApp {
31943194
fn fmt_nest(&self, f: &mut std::fmt::Formatter<'_>, level: usize) -> std::fmt::Result {
31953195
writeln!(f, "{}", self.obj)?;
31963196
if let Some(attr_name) = &self.attr_name {
3197-
writeln!(f, "{}", attr_name)?;
3197+
writeln!(f, "{attr_name}")?;
31983198
}
31993199
writeln!(f, "(")?;
32003200
self.args.fmt_nest(f, level + 1)?;
@@ -4446,11 +4446,11 @@ impl fmt::Display for VarName {
44464446
#[pymethods]
44474447
impl VarName {
44484448
pub fn __repr__(&self) -> String {
4449-
format!("VarName({})", self)
4449+
format!("VarName({self})")
44504450
}
44514451

44524452
pub fn __str__(&self) -> String {
4453-
format!("VarName({})", self)
4453+
format!("VarName({self})")
44544454
}
44554455

44564456
#[staticmethod]
@@ -4715,11 +4715,11 @@ impl From<Identifier> for Expr {
47154715
#[pymethods]
47164716
impl Identifier {
47174717
pub fn __repr__(&self) -> String {
4718-
format!("Identifier({})", self)
4718+
format!("Identifier({self})")
47194719
}
47204720

47214721
pub fn __str__(&self) -> String {
4722-
format!("Identifier({})", self)
4722+
format!("Identifier({self})")
47234723
}
47244724

47254725
pub fn is_const(&self) -> bool {
@@ -5245,11 +5245,11 @@ impl VarSignature {
52455245
}
52465246

52475247
pub fn __repr__(&self) -> String {
5248-
format!("VarSignature({})", self)
5248+
format!("VarSignature({self})")
52495249
}
52505250

52515251
pub fn __str__(&self) -> String {
5252-
format!("VarSignature({})", self)
5252+
format!("VarSignature({self})")
52535253
}
52545254
}
52555255

@@ -5704,8 +5704,8 @@ pub enum GuardClause {
57045704
impl NestedDisplay for GuardClause {
57055705
fn fmt_nest(&self, f: &mut std::fmt::Formatter<'_>, _level: usize) -> std::fmt::Result {
57065706
match self {
5707-
Self::Condition(cond) => write!(f, "{}", cond),
5708-
Self::Bind(def) => write!(f, "{}", def),
5707+
Self::Condition(cond) => write!(f, "{cond}"),
5708+
Self::Bind(def) => write!(f, "{def}"),
57095709
}
57105710
}
57115711
}

src/dummy.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ impl PackageManagerRunner {
454454
{
455455
Ok(out) => ExitStatus::new(out.status.code().unwrap_or(0), 0, 0),
456456
Err(err) => {
457-
eprintln!("Error: {}", err);
457+
eprintln!("Error: {err}");
458458
ExitStatus::ERR1
459459
}
460460
}

0 commit comments

Comments
 (0)