chore: remove dead code

Remove code unreachable from any binary, test (including
integration-tagged tests), or known downstream consumer:

- apps/evm/cmd/post_tx_cmd.go: PostTxCmd was added in #2888 but never
  registered in the CLI; ev-abci carries its own copy
- apps/evm/server: handleChainID was never routed; eth_chainId falls
  through to the execution RPC proxy
- apps/testapp/kv: HTTPServer.Stop is redundant, Start already shuts
  down via context cancellation
- node: MockTester has no users
- pkg/da/types: SplitID duplicates pkg/da/jsonrpc.SplitID, which is
  the copy in use
- pkg/store: GetPrefixEntries has no callers

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: tac0turtle

apps/evm/cmd/post_tx_cmd.go

@@ -8,7 +8,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"strconv"
 	"strings"
 	"time"
 
@@ -175,19 +174,6 @@ func (s *ForceInclusionServer) handleJSONRPC(w http.ResponseWriter, r *http.Requ
 	}
 }
 
-// handleChainID handles eth_chainId requests
-func (s *ForceInclusionServer) handleChainID(w http.ResponseWriter, req *JSONRPCRequest) {
-	// Convert chain ID string to integer
-	chainIDInt, err := strconv.ParseUint(s.genesis.ChainID, 10, 64)
-	if err != nil {
-		s.writeError(w, req.ID, InternalError, fmt.Sprintf("invalid chain ID: %v", err))
-		return
-	}
-	// Return the chain ID as a hex string prefixed with 0x
-	chainID := fmt.Sprintf("0x%x", chainIDInt)
-	s.writeSuccess(w, req.ID, chainID)
-}
-
 // proxyToExecutionRPC forwards unknown RPC methods to the execution RPC endpoint
 func (s *ForceInclusionServer) proxyToExecutionRPC(w http.ResponseWriter, req *JSONRPCRequest, body []byte) {
 	if s.executionRPCURL == "" {

apps/evm/server/force_inclusion.go

@@ -76,11 +76,6 @@ func (hs *HTTPServer) Start(ctx context.Context) error {
 	}
 }
 
-// Stop shuts down the HTTP server
-func (hs *HTTPServer) Stop() error {
-	return hs.server.Close()
-}
-
 // handleTx handles transaction submissions
 // POST /tx with raw binary data or text in request body
 // It is recommended to use transactions in the format "key=value" to be consistent

apps/testapp/kv/http_server.go

@@ -23,22 +23,6 @@ const (
 	Store
 )
 
-// MockTester is a mock testing.T
-type MockTester struct {
-}
-
-// Fail is used to fail the test
-func (m MockTester) Fail() {}
-
-// FailNow is used to fail the test immediately
-func (m MockTester) FailNow() {}
-
-// Logf is used to log a message to the test logger
-func (m MockTester) Logf(format string, args ...any) {}
-
-// Errorf is used to log an error to the test logger
-func (m MockTester) Errorf(format string, args ...any) {}
-
 func waitForFirstBlock(node Node, source Source) error {
 	return waitForAtLeastNBlocks(node, 1, source)
 }

node/helpers.go

@@ -1,8 +1,6 @@
 package da
 
 import (
-	"encoding/binary"
-	"fmt"
 	"time"
 )
 
@@ -73,16 +71,6 @@ type BaseResult struct {
 	Timestamp time.Time
 }
 
-// SplitID splits an ID into a height and a commitment.
-// if len(id) <= 8, it returns 0 and nil.
-func SplitID(id []byte) (uint64, []byte, error) {
-	if len(id) <= 8 {
-		return 0, nil, fmt.Errorf("invalid ID length: %d", len(id))
-	}
-	commitment := id[8:]
-	return binary.LittleEndian.Uint64(id[:8]), commitment, nil
-}
-
 // SubscriptionEvent is a namespace-agnostic signal that a blob was finalized at
 // Height on the DA layer. Produced by Subscribe and consumed by DA followers.
 type SubscriptionEvent struct {

pkg/da/types/types.go

@@ -1,13 +1,11 @@
 package store
 
 import (
-	"context"
 	"path/filepath"
 	"strings"
 
 	ds "github.com/ipfs/go-datastore"
 	ktds "github.com/ipfs/go-datastore/keytransform"
-	dsq "github.com/ipfs/go-datastore/query"
 	badger4 "github.com/ipfs/go-ds-badger4"
 )
 
@@ -30,15 +28,6 @@ func NewEvNodeKVStore(kvStore ds.Batching) ds.Batching {
 	return NewPrefixKVStore(kvStore, EvPrefix)
 }
 
-// GetPrefixEntries retrieves all entries in the datastore whose keys have the supplied prefix
-func GetPrefixEntries(ctx context.Context, store ds.Datastore, prefix string) (dsq.Results, error) {
-	results, err := store.Query(ctx, dsq.Query{Prefix: prefix})
-	if err != nil {
-		return nil, err
-	}
-	return results, nil
-}
-
 // GenerateKey creates a key from a slice of string fields, joining them with slashes.
 func GenerateKey(fields []string) string {
 	// Pre-calculate total size to avoid re-allocation.