-
Notifications
You must be signed in to change notification settings - Fork 96
E2556 - Reimplement Assign Reviewers and Create Teams pages #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cammyj1122
wants to merge
26
commits into
expertiza:main
Choose a base branch
from
cammyj1122:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated AssignReviewer.tsx to normalize persisted data from localStorage, ensuring users, teams, participants, and responses always exist as arrays. This prevents runtime errors when accessing assignments with stale or incomplete data (e.g., id #2). Changes made: - AssignReviewer.tsx: added normalizePersist helper and integrated it into persisted state handling. - App.tsx: removed old AssignReviewer loader import/usage to rely purely on localStorage-driven demo data. - package.json: updated to reflect dependency adjustments for linting and React hook rules compliance. No other files were updated in this commit.
Changed "http://localhost:3002/api/v1/" to "http://localhost:3002/" Reason: Was throwing 404 errors since backend doesnt have api/v1 routing
fix: update frontend baseURL to match backend route changes (removed /api/v1) (expertiza#109)
Assignment reviewer page update
completed create teams page
…ted on functionality
…-reviewers into dev
added edits to create teams page
…ate Teams pages to grab elements for testing.
…n-reviewers into dev
…AssignReviewer.test.tsx. Returned package.json to original state.
Fixed Create Teams and Tests
Merge expertiza main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.