Middleware called for no reason

[SkypLabs]

Hi,

In a Node.js application using Express 4, I introduced a new custom middleware for handling user authentication. The middleware, called authClient, is only used in one single request handler and nowhere else:

router.get("/:clientId", authClient, async (req: Request, res: Response) => {
...
}

However, when running integration tests, all tests related to testing the absence of path parameters, even in other request handlers attached to the same router, fail because they called authClient, which is not supposed to happen.

Does anyone have any idea why?

Thanks!

[SkypLabs]

Someone found the solution for me.

Actually, the requests sent by the failing tests, even though they were supposed to test other request handlers, were already caught and processed by router.get("/:clientId", ... by mistake, even before I introduced the new authClient middleware. This was due to router.get("/:clientId", ... located at the beginning of the source code file, before the other router's request handlers.

The solution was to move the router.get("/:clientId", ... request handler to the bottom of the source code file, and to turn mandatory path parameters into optional ones to make sure they still get caught by the right request handlers.