Another attempt to streamline process handlign for preview on Windows

Author: cezaraugusto

programs/develop/webpack/dev-server/index.ts

@@ -29,13 +29,15 @@ function closeAll(devServer: RspackDevServer, portManager: PortManager) {
     .then(async () => {
       // Terminate the current instance
       await portManager.terminateCurrentInstance()
-      process.exit()
+      // Allow browser plugin signal handlers to complete cleanup
+      setTimeout(() => process.exit(), 500)
     })
     .catch(async (error) => {
       console.log(messages.extensionJsRunnerError(error))
       // Still try to terminate the instance
       await portManager.terminateCurrentInstance()
-      process.exit(1)
+      // Allow browser plugin signal handlers to complete cleanup
+      setTimeout(() => process.exit(1), 500)
     })
 }
 
@@ -291,10 +293,8 @@ export async function devServer(
     await cleanup()
   }
 
-  process.removeAllListeners?.('SIGINT')
-  process.removeAllListeners?.('SIGTERM')
-  process.removeAllListeners?.('SIGHUP')
-  process.removeAllListeners?.('ERROR')
+  // Do not remove other listeners; let browser plugins receive signals too.
+  // Register our cleanup alongside theirs so Ctrl+C terminates the browser.
   process.on('ERROR', cancelAndCleanup)
   process.on('SIGINT', cancelAndCleanup)
   process.on('SIGTERM', cancelAndCleanup)

programs/develop/webpack/plugin-browsers/run-chromium/chromium-launch/process-handlers.ts

@@ -1,4 +1,4 @@
-import {ChildProcess} from 'child_process'
+import {ChildProcess, spawn} from 'child_process'
 import * as messages from '../../browsers-lib/messages'
 import type {DevOptions} from '../../../webpack-types'
 
@@ -14,6 +14,20 @@ export function setupProcessSignalHandlers(
       }
 
       if (child && !child.killed) {
+        // On Windows, ensure the entire process tree is terminated.
+        // Chromium spawns multiple processes; taskkill /T /F is most reliable.
+        if (process.platform === 'win32') {
+          try {
+            spawn('taskkill', ['/PID', String(child.pid), '/T', '/F'], {
+              stdio: 'ignore',
+              windowsHide: true
+            }).on('error', () => {
+              // Ignore errors from taskkill
+            })
+          } catch {
+            // Ignore
+          }
+        }
         if (process.env.EXTENSION_ENV === 'development') {
           console.log(messages.enhancedProcessManagementTerminating(browser))
         }