-
-
Notifications
You must be signed in to change notification settings - Fork 351
File path auto-completion accounts for typical OS filesystem case sensitivity #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File path auto-completion accounts for typical OS filesystem case sensitivity #2694
Conversation
|
\ci fast |
729b9a4 to
59b6a14
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2694 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 141 141
Lines 12484 12489 +5
=======================================
+ Hits 12050 12055 +5
Misses 434 434 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
59b6a14 to
ca33a04
Compare
|
\ci main |
|
nice @skusel ! let me know when this is ready for review. |
|
\ci full |
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseSensitive.log
Show resolved
Hide resolved
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes and a question
59d8371 to
6a42562
Compare
6a42562 to
bfc3eb3
Compare
testing/baselines/TestInteractionConsoleAutoCompleteDirCaseSensitive.png
Show resolved
Hide resolved
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still some questions
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
testing/recordings/TestInteractionConsoleAutoCompleteDirCaseInsensitiveLowercaseF.log
Outdated
Show resolved
Hide resolved
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Only remain the cleaning up of log files. I've cleaned up one of them as an example, Ill let you handle the others :)
Thanks for the example and review! I have cleaned up all the log files and pushed up the changes. |
fafd0da to
ffc3028
Compare
|
Thanks for the contribution @skusel ! |
…vity Enhanced file path auto-completion to account for typical OS filesystem case sensitivity.
Describe your changes
Enhanced file path auto-completion to account for typical OS filesystem case sensitivity.
By default, Windows and macOS use case-insensitive filesystems, and Linux typically uses case-sensitive filesystems. Previously, file path auto-completion in F3D was always case-sensitive.
To determine with 100% certainty whether a filesystem is case-sensitive, I would have to create two files with the same name that differ only in casing in the filesystem of interest (multiple filesystems can be present on a system). This approach felt over engineered, so I used the OS filesystem case-sensitivity defaults to determine when to use case-sensitive vs case-insensitive file path autocompletion.
In the application tests, I added a
WORKING_DIRoption to thef3d_testfunction that changes the test's working directory. This was done so I could test these changes on directories that differed only in casing, without worrying about how the file path separators differ across operating systems.Issue ticket number and link if any
#2681
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.