Parse define targets from pyrefly call graphs

Summary: As titled.

Reviewed By: tianhan0

Differential Revision: D85775948

fbshipit-source-id: cc486836f4824a03a426c17b2867e899fe0a9893

Author: arthaud

source/interprocedural/pyreflyApi.ml

@@ -1456,11 +1456,25 @@ module ModuleCallGraphs = struct
       >>| fun if_called -> { if_called }
   end
 
+  module JsonDefineCallees = struct
+    type t = { define_targets: JsonCallTarget.t list }
+
+    let from_json json =
+      let open Core.Result.Monad_infix in
+      let parse_call_target_list targets =
+        targets |> List.map ~f:JsonCallTarget.from_json |> Result.all
+      in
+      JsonUtil.get_list_member json "define_targets"
+      >>= parse_call_target_list
+      >>| fun define_targets -> { define_targets }
+  end
+
   module JsonExpressionCallees = struct
     type t =
       | Call of JsonCallCallees.t
       | Identifier of JsonIdentifierCallees.t
       | AttributeAccess of JsonAttributeAccessCallees.t
+      | Define of JsonDefineCallees.t
 
     let from_json json =
       let open Core.Result.Monad_infix in
@@ -1473,6 +1487,8 @@ module ModuleCallGraphs = struct
       | `Assoc [("AttributeAccess", attribute_access_callees)] ->
           JsonAttributeAccessCallees.from_json attribute_access_callees
           >>| fun attribute_access_callees -> AttributeAccess attribute_access_callees
+      | `Assoc [("Define", define_callees)] ->
+          JsonDefineCallees.from_json define_callees >>| fun define_callees -> Define define_callees
       | _ ->
           Error (FormatError.UnexpectedJsonType { json; message = "expected expression callees" })
   end
@@ -4099,13 +4115,21 @@ module ReadOnly = struct
         if_called;
       }
     in
+    let instantiate_define_callees { JsonDefineCallees.define_targets } =
+      {
+        CallGraph.DefineCallees.define_targets = List.map ~f:instantiate_call_target define_targets;
+        decorated_targets = [];
+      }
+    in
     let instantiate_expression_callees = function
       | JsonExpressionCallees.Call callees ->
           ExpressionCallees.Call (instantiate_call_callees callees)
       | JsonExpressionCallees.Identifier callees ->
           ExpressionCallees.Identifier (instantiate_identifier_callees callees)
       | JsonExpressionCallees.AttributeAccess callees ->
           ExpressionCallees.AttributeAccess (instantiate_attribute_access_callees callees)
+      | JsonExpressionCallees.Define callees ->
+          ExpressionCallees.Define (instantiate_define_callees callees)
     in
     let instantiate_call_edge ~key:location ~data:callees call_graph =
       let callees = instantiate_expression_callees callees in

source/interprocedural/test/callGraphTest.ml

@@ -2032,6 +2032,7 @@ let test_call_graph_of_define =
            ();
       labeled_test_case __FUNCTION__ __LINE__
       @@ assert_call_graph_of_define
+           ~skip_for_pyrefly:false
            ~_migrated_to_pyrefly:false
            ~source:
              {|
@@ -2075,6 +2076,29 @@ let test_call_graph_of_define =
                         ]
                       ()) );
              ]
+           ~pyrefly_expected:
+             [
+               ( "5:2-7:12",
+                 ExpressionCallees.from_define
+                   (DefineCallees.create
+                      ~define_targets:
+                        [
+                          CallTarget.create_regular
+                            ~return_type:None
+                            (Target.Regular.Function { name = "test.foo.inner"; kind = Decorated });
+                        ]
+                      ()) );
+               ( "9:2-9:9",
+                 ExpressionCallees.from_call
+                   (CallCallees.create
+                      ~call_targets:
+                        [
+                          CallTarget.create_regular
+                            ~return_type:(Some ReturnType.integer)
+                            (Target.Regular.Function { name = "test.foo.inner"; kind = Decorated });
+                        ]
+                      ()) );
+             ]
            ();
       labeled_test_case __FUNCTION__ __LINE__
       @@ assert_call_graph_of_define
@@ -2598,6 +2622,7 @@ let test_call_graph_of_define =
            ();
       labeled_test_case __FUNCTION__ __LINE__
       @@ assert_call_graph_of_define
+           ~skip_for_pyrefly:false
            ~_migrated_to_pyrefly:true
            ~source:
              {|
@@ -2632,6 +2657,7 @@ let test_call_graph_of_define =
            ();
       labeled_test_case __FUNCTION__ __LINE__
       @@ assert_call_graph_of_define
+           ~skip_for_pyrefly:false
            ~_migrated_to_pyrefly:true
            ~source:
              {|