Commit 376183e
Fix ImageProps default values (#54545)
Summary:
Pull Request resolved: #54545
Changelog: [Internal]
Currently these default values
https://reactnative.dev/docs/image#resizemethod-android
https://reactnative.dev/docs/image#resizemultiplier-android
are not correctly treated in C++ code as parsing bails out here:
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177
By setting default values in the struct, we can fix it
Reviewed By: sbuggay
Differential Revision: D87083023
fbshipit-source-id: b8e16d0f6732392bafee01848c1c516e91ab806b1 parent 5d9cb80 commit 376183e
File tree
2 files changed
+4
-4
lines changed- packages/react-native/ReactCommon/react/renderer/components/image
2 files changed
+4
-4
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
| 36 | + | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
0 commit comments