Set default hermes variable to SH stable, remove legacy hermes (#54522)

Summary:

As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT`
should be set to SH stable. Note that this will cause fantom tests
to be skipped in OSS for now.

Changelog: [Internal]

Differential Revision: D86885030

Author: lavenzg

packages/react-native/src/private/__tests__/MemoryBaseline-itest.js

@@ -29,12 +29,12 @@ declare var performance: Performance;
  */
 const MEMORY_LIMITS_KB = {
   environmentSetup: {
-    dev: 1000,
-    opt: 500,
+    dev: 1200,
+    opt: 600,
   },
   basicSurfaceRender: {
-    dev: 1200,
-    opt: 700,
+    dev: 1700,
+    opt: 900,
   },
 };
 

private/react-native-fantom/runner/formatFantomConfig.js

@@ -82,8 +82,6 @@ function formatModesShort(overrides: PartialFantomTestConfig) {
 
 function formatFantomHermesVariant(hermesVariant: HermesVariant): string {
   switch (hermesVariant) {
-    case FantomTestConfigHermesVariant.Hermes:
-      return 'hermes';
     case FantomTestConfigHermesVariant.StaticHermesStable:
       return 'shermes 🆕';
     case FantomTestConfigHermesVariant.StaticHermesExperimental:

private/react-native-fantom/runner/getFantomTestConfigs.js

@@ -59,7 +59,8 @@ export const FantomTestConfigHermesVariant = HermesVariant;
 export const DEFAULT_IS_NATIVE_OPTIMIZED: boolean = false;
 export const DEFAULT_IS_JS_OPTIMIZED: boolean = false;
 export const DEFAULT_IS_JS_BYTECODE: boolean = false;
-export const DEFAULT_HERMES_VARIANT: HermesVariant = HermesVariant.Hermes;
+export const DEFAULT_HERMES_VARIANT: HermesVariant =
+  HermesVariant.StaticHermesStable;
 
 export const DEFAULT_FEATURE_FLAGS: FantomTestConfigFeatureFlags = {
   common: {},
@@ -147,8 +148,7 @@ export function getOverrides(
  * - `fantom_mode`: specifies the level of optimization to compile the test
  *  with. Valid values are `dev` and `opt`.
  * - `fantom_hermes_variant`: specifies the Hermes variant to use to run the
- *  test. Valid values are `hermes`, `static_hermes_stable` and
- * `static_hermes_experimental`.
+ *  test. Valid values are `static_hermes_stable` and `static_hermes_experimental`.
  * - `fantom_flags`: specifies the configuration for common and JS-only feature
  *  flags. They can be specified in the same pragma or in different ones, and
  *  the format is `<flag_name>:<value>`.
@@ -294,9 +294,6 @@ export default function getFantomTestConfigs(
     const hermesVariant = maybeHermesVariant;
 
     switch (hermesVariant) {
-      case 'hermes':
-        config.hermesVariant = HermesVariant.Hermes;
-        break;
       case 'static_hermes_stable':
         config.hermesVariant = HermesVariant.StaticHermesStable;
         break;
@@ -305,7 +302,6 @@ export default function getFantomTestConfigs(
         break;
       case '*':
         configVariations.push([
-          {hermesVariant: HermesVariant.Hermes},
           {hermesVariant: HermesVariant.StaticHermesStable},
           {hermesVariant: HermesVariant.StaticHermesExperimental},
         ]);

private/react-native-fantom/runner/runner.js

@@ -43,7 +43,6 @@ import {
   updateSnapshotsAndGetJestSnapshotResult,
 } from './snapshotUtils';
 import {
-  HermesVariant as HermesVariantEnum,
   getDebugInfoFromCommandResult,
   printConsoleLog,
   runCommand,
@@ -264,10 +263,7 @@ module.exports = async function runTest(
       continue;
     }
 
-    if (
-      EnvironmentOptions.isOSS &&
-      testConfig.hermesVariant !== HermesVariantEnum.Hermes
-    ) {
+    if (EnvironmentOptions.isOSS) {
       testResultsByConfig.push(
         skippedTestResults({
           ancestorTitles: [

private/react-native-fantom/runner/utils.js

@@ -18,7 +18,6 @@ import {SourceMapConsumer} from 'source-map';
 const BUCK_ISOLATION_DIR = 'react-native-fantom-buck-out';
 
 export enum HermesVariant {
-  Hermes,
   StaticHermesStable, // Static Hermes Stable
   // This creates too many combinations and it's not worth the cost for now.
   StaticHermesExperimental, // Static Hermes Trunk
@@ -31,8 +30,6 @@ export function getBuckOptionsForHermes(
     ? ['-c hermes.memory_instrumentation=true']
     : [];
   switch (variant) {
-    case HermesVariant.Hermes:
-      return baseOptions;
     case HermesVariant.StaticHermesStable:
       return [...baseOptions, '-c hermes.static_hermes=stable'];
     case HermesVariant.StaticHermesExperimental:
@@ -42,8 +39,6 @@ export function getBuckOptionsForHermes(
 
 export function getHermesCompilerTarget(variant: HermesVariant): string {
   switch (variant) {
-    case HermesVariant.Hermes:
-      return '//xplat/hermes/tools/hermesc:hermesc';
     case HermesVariant.StaticHermesStable:
       return '//xplat/shermes/stable:hermesc';
     case HermesVariant.StaticHermesExperimental:

private/react-native-fantom/src/__tests__/__snapshots__/expect-itest.js.snap

@@ -35,10 +35,10 @@ exports[`expect toMatchSnapshot() complex types 8`] = `/asd/`;
 
 exports[`expect toMatchSnapshot() complex types 9`] = `
 Promise {
-  "_h": 0,
-  "_i": 0,
-  "_j": null,
-  "_k": null,
+  "_A": null,
+  "_x": 0,
+  "_y": 0,
+  "_z": null,
 }
 `;
 

private/react-native-fantom/src/__tests__/expect-itest.js

@@ -6,6 +6,7 @@
  *
  * @flow strict-local
  * @format
+ * @fantom_hermes_variant static_hermes_stable
  */
 
 import * as React from 'react';