Skip to content

Commit d52b9d2

Browse files
tsaichienmeta-codesync[bot]
authored andcommitted
Add JSI_UNSTABLE flag (#54547)
Summary: Pull Request resolved: #54547 We want to have a proper way of releasing new JSI features, rather than releasing into JSI as they are added. To do this, we are adding a new `JSI_UNSTABLE` flag that will gate new features. Until Hermes releases a new version, all of these "unstable" features are subject to change. Interfaces may be modified, API behavior may be changed, etc. When Hermes release a new version, the new additions will be moved out of the "unstable" status and become frozen. This diff adds the `JSI_UNSTABLE` flag to JSI and adds corresponding changes to the BUCK build. Later diffs will use this gate new APIs. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D85915163 fbshipit-source-id: b2f754af4bb53db8dfe837e3ea2e2543d691754d
1 parent 2d6a323 commit d52b9d2

File tree

1 file changed

+6
-0
lines changed
  • packages/react-native/ReactCommon/jsi/jsi

1 file changed

+6
-0
lines changed

packages/react-native/ReactCommon/jsi/jsi/jsi.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,12 @@ class JSI_EXPORT NativeState {
252252
virtual ~NativeState();
253253
};
254254

255+
// JSI_UNSTABLE gates features that will be released with a Hermes version in
256+
// the future. Until released, these features may be subject to change. After
257+
// release, these features will be moved out of JSI_UNSTABLE and become frozen.
258+
#ifdef JSI_UNSTABLE
259+
#endif // JSI_UNSTABLE
260+
255261
/// Represents a JS runtime. Movable, but not copyable. Note that
256262
/// this object may not be thread-aware, but cannot be used safely from
257263
/// multiple threads at once. The application is responsible for

0 commit comments

Comments
 (0)