Feature/number formatter with optional exponential separator#682
Open
dedeibel wants to merge 4 commits intofair-acc:mainfrom
Open
Feature/number formatter with optional exponential separator#682dedeibel wants to merge 4 commits intofair-acc:mainfrom
dedeibel wants to merge 4 commits intofair-acc:mainfrom
Conversation
added 2 commits
December 9, 2024 08:46
dedeibel
force-pushed
the
feature/number-formatter-with-optional-exponential-separator
branch
from
ff05246 to
50668f0
Compare
dedeibel
force-pushed
the
feature/number-formatter-with-optional-exponential-separator
branch
from
50668f0 to
295bc96
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberFormatterImplworks nicely but I wanted to be able provide a separator character before the exponent part. A good character would be NARROW NO-BREAK SPACE (0x202f).The current implementation does not allow a separator character and also only works with ASCII chars.
I tried to extend it to be able to use UTF-8 charset. The original implementation was clearly optimized for performance and I don't think this would be impacted by the change. If no UTF-8 character is used, there should be almost no change in runtime.
No default separator is used and the overall default behaviour unchanged.
Please consider the change for integration.