feat: separate proto files into standalone crate #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christopherwxyz is attempting to deploy a commit to the farcaster Team on Vercel. A member of the Team first needs to authorize it. |
christopherwxyz
force-pushed
the
feat/proto-crate
branch
from
7119bb8 to
744150f
Compare
Extract protocol buffer definitions into a separate `snapchain-proto` crate so consumers can import protos without depending on the entire snapchain project. Changes: - Create `proto/` workspace member with its own Cargo.toml and build.rs - Move proto definitions from `src/proto/` to `proto/definitions/` - Move proto-only impls (Height, ShardHash, Message, etc.) to proto crate - Add extension traits for methods requiring main crate types: - CommitsExt for commit certificate conversion - FullProposalExt for proposer address - HubEventExt for event construction - HubEventStorageExt for storage operations - Update imports throughout codebase to use extension traits - Rename HubEvent::from() to HubEvent::new_event() to avoid trait conflict
christopherwxyz
force-pushed
the
feat/proto-crate
branch
from
744150f to
2d9182b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
snapchain-protocrate so consumers can import protos without depending on the entire snapchain projectproto/as a workspace memberChanges
proto/workspace member with its ownCargo.tomlandbuild.rssrc/proto/toproto/definitions/CommitsExtfor commit certificate conversionFullProposalExtfor proposer addressHubEventExtfor event constructionHubEventStorageExtfor storage operationsHubEvent::from()toHubEvent::new_event()to avoid trait conflict withstd::convert::FromTest plan