Document import_from_gem #1157
Open
Document import_from_gem #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@lacostej could you rebase your branch to trigger Netlify preview again? 🙏 |
lacostej
force-pushed
the
feature/import_from_gem
branch
from
40fd855 to
631cffc
Compare
lacostej
force-pushed
the
feature/import_from_gem
branch
from
631cffc to
ebc036d
Compare
Collaborator
Author
done |
rogerluan
requested changes
Jan 19, 2024
Member
rogerluan
left a comment
rogerluan
left a comment
There was a problem hiding this comment.
Just some nitpicks, otherwise LGTM 😊
Comment on lines
+125
to
+126
| import_from_gem(gem_name: 'my_gem', | ||
| paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*']) |
Member
There was a problem hiding this comment.
uh weird indentation? 👀 Can we do e.g.:
Suggested change
| import_from_gem(gem_name: 'my_gem', | |
| paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*']) | |
| import_from_gem(gem_name: 'my_gem', paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*']) |
or
Suggested change
| import_from_gem(gem_name: 'my_gem', | |
| paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*']) | |
| import_from_gem( | |
| gem_name: 'my_gem', | |
| paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'], | |
| ) |
or
Suggested change
| import_from_gem(gem_name: 'my_gem', | |
| paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*']) | |
| import_from_gem(gem_name: 'my_gem', paths: [ | |
| 'fastlane/Fastfile', | |
| 'fastlane/Fastfile_*', | |
| ]) |
? 🙈
Member
There was a problem hiding this comment.
The intended indentation might've been this:
Suggested change
| import_from_gem(gem_name: 'my_gem', | |
| paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*']) | |
| import_from_gem(gem_name: 'my_gem', | |
| paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*']) |
But I'm not a fan, hence why I suggested the 3 others above 😂 I'd pick the first one because I don't care much about horizontal line length, but the others are fine too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to fastlane/fastlane#20294