fix: Materialize API - ODFV views not looked-up (thinks views non existant) - crashes materialize (#5716)

* add pull_all_from_table_or_query for clickhouse, to align with new materialization logic (calling it)

Signed-off-by: lukas.valatka <[email protected]>

* fix - ensure on demand feature views can be checked too

Signed-off-by: lukas.valatka <[email protected]>

---------

Signed-off-by: lukas.valatka <[email protected]>
Co-authored-by: Lukas Valatka <[email protected]>

Author: 2 people

sdk/python/feast/feature_server.py

@@ -344,18 +344,27 @@ async def push(request: PushFeaturesRequest) -> None:
     async def _get_feast_object(
         feature_view_name: str, allow_registry_cache: bool
     ) -> FeastObject:
+        # FIXME: this logic repeated at least 3 times in the codebase - should be centralized
+        # in logging, in server and in feature_store (Python SDK)
         try:
-            return await run_in_threadpool(
-                store.get_stream_feature_view,
-                feature_view_name,
-                allow_registry_cache=allow_registry_cache,
-            )
-        except FeatureViewNotFoundException:
             return await run_in_threadpool(
                 store.get_feature_view,
                 feature_view_name,
                 allow_registry_cache=allow_registry_cache,
             )
+        except FeatureViewNotFoundException:
+            try:
+                return await run_in_threadpool(
+                    store.get_on_demand_feature_view,
+                    feature_view_name,
+                    allow_registry_cache=allow_registry_cache,
+                )
+            except FeatureViewNotFoundException:
+                return await run_in_threadpool(
+                    store.get_stream_feature_view,
+                    feature_view_name,
+                    allow_registry_cache=allow_registry_cache,
+                )
 
     @app.post("/write-to-online-store", dependencies=[Depends(inject_user_details)])
     async def write_to_online_store(request: WriteToFeatureStoreRequest) -> None: