Skip to content

Commit ce4490c

Browse files
Srihari1192hao-xu5
authored andcommitted
test: Update latest Notebook template for feast Notebook tests
Signed-off-by: Srihari <[email protected]>
1 parent 5a5ccde commit ce4490c

File tree

1 file changed

+2
-71
lines changed

1 file changed

+2
-71
lines changed

infra/feast-operator/test/e2e_rhoai/resources/custom-nb.yaml

Lines changed: 2 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ apiVersion: kubeflow.org/v1
99
kind: Notebook
1010
metadata:
1111
annotations:
12-
notebooks.opendatahub.io/inject-oauth: "true"
12+
notebooks.opendatahub.io/inject-auth: "true"
1313
notebooks.opendatahub.io/last-size-selection: Small
14-
notebooks.opendatahub.io/oauth-logout-url: https://odh-dashboard-{{.OpenDataHubNamespace}}.{{.IngressDomain}}/notebookController/kube-3aadmin/home
1514
opendatahub.io/link: https://jupyter-nb-kube-3aadmin-{{.Namespace}}.{{.IngressDomain}}/notebook/{{.Namespace}}/jupyter-nb-kube-3aadmin
1615
opendatahub.io/username: {{.Username}}
1716
generation: 1
@@ -78,80 +77,12 @@ spec:
7877
- mountPath: /opt/app-root/notebooks
7978
name: {{.NotebookConfigMapName}}
8079
workingDir: /opt/app-root/src
81-
- args:
82-
- --provider=openshift
83-
- --https-address=:8443
84-
- --http-address=
85-
- --openshift-service-account=jupyter-nb-kube-3aadmin
86-
- --cookie-secret-file=/etc/oauth/config/cookie_secret
87-
- --cookie-expire=24h0m0s
88-
- --tls-cert=/etc/tls/private/tls.crt
89-
- --tls-key=/etc/tls/private/tls.key
90-
- --upstream=http://localhost:8888
91-
- --upstream-ca=/var/run/secrets/kubernetes.io/serviceaccount/ca.crt
92-
- --skip-auth-regex=^(?:/notebook/test-feast-wb/jupyter-nb-kube-3aadmin)?/api$
93-
- --email-domain=*
94-
- --skip-provider-button
95-
- --openshift-sar={"verb":"get","resource":"notebooks","resourceAPIGroup":"kubeflow.org","resourceName":"jupyter-nb-kube-3aadmin","namespace":$(NAMESPACE)}
96-
- --logout-url=https://odh-dashboard-{{.OpenDataHubNamespace}}.{{.IngressDomain}}/notebookController/kube-3aadmin/home
97-
env:
98-
- name: NAMESPACE
99-
valueFrom:
100-
fieldRef:
101-
fieldPath: metadata.namespace
102-
image: registry.redhat.io/openshift4/ose-oauth-proxy:v4.10
103-
imagePullPolicy: Always
104-
livenessProbe:
105-
failureThreshold: 3
106-
httpGet:
107-
path: /oauth/healthz
108-
port: oauth-proxy
109-
scheme: HTTPS
110-
initialDelaySeconds: 30
111-
periodSeconds: 5
112-
successThreshold: 1
113-
timeoutSeconds: 1
114-
name: oauth-proxy
115-
ports:
116-
- containerPort: 8443
117-
name: oauth-proxy
118-
protocol: TCP
119-
readinessProbe:
120-
failureThreshold: 3
121-
httpGet:
122-
path: /oauth/healthz
123-
port: oauth-proxy
124-
scheme: HTTPS
125-
initialDelaySeconds: 5
126-
periodSeconds: 5
127-
successThreshold: 1
128-
timeoutSeconds: 1
129-
resources:
130-
limits:
131-
cpu: 100m
132-
memory: 64Mi
133-
requests:
134-
cpu: 100m
135-
memory: 64Mi
136-
volumeMounts:
137-
- mountPath: /etc/oauth/config
138-
name: oauth-config
139-
- mountPath: /etc/tls/private
140-
name: tls-certificates
14180
enableServiceLinks: false
142-
serviceAccountName: jupyter-nb-kube-3aadmin
81+
serviceAccountName: default
14382
volumes:
14483
- name: jupyterhub-nb-kube-3aadmin-pvc
14584
persistentVolumeClaim:
14685
claimName: {{.NotebookPVC}}
147-
- name: oauth-config
148-
secret:
149-
defaultMode: 420
150-
secretName: jupyter-nb-kube-3aadmin-oauth-config
151-
- name: tls-certificates
152-
secret:
153-
defaultMode: 420
154-
secretName: jupyter-nb-kube-3aadmin-tls
15586
- name: {{.NotebookConfigMapName}}
15687
configMap:
15788
name: {{.NotebookConfigMapName}}

0 commit comments

Comments
 (0)