Merge pull request #1070 from 06kellyjac/fix_type_issue

fix: correct typing for ConfigLoader env

Author: JamieSlome

.github/workflows/ci.yml

@@ -45,6 +45,12 @@ jobs:
     - name: Install dependencies
       run: npm i
 
+    # for now only check the types of the server
+    # tsconfig isn't quite set up right to respect what vite accepts
+    # for the frontend code
+    - name: Check Types (Server)
+      run: npm run check-types:server
+
     - name: Test
       id: test
       run: |

package.json

@@ -14,6 +14,7 @@
     "build-lib": "./scripts/build-for-publish.sh",
     "restore-lib": "./scripts/undo-build.sh",
     "check-types": "tsc",
+    "check-types:server": "tsc --project tsconfig.publish.json --noEmit",
     "test": "NODE_ENV=test ts-mocha './test/**/*.test.js' --exit",
     "test-coverage": "nyc npm run test",
     "test-coverage-ci": "nyc --reporter=lcovonly --reporter=text npm run test",

src/config/ConfigLoader.ts

@@ -317,7 +317,8 @@ export class ConfigLoader extends EventEmitter {
         cwd: process.cwd(),
         env: {
           // dont wait for credentials; the command should be sufficiently authed
-          GIT_TERMINAL_PROMPT: 0,
+          // https://git-scm.com/docs/git#Documentation/git.txt-codeGITTERMINALPROMPTcode
+          GIT_TERMINAL_PROMPT: 'false',
           ...process.env,
           ...(source.auth?.type === 'ssh'
             ? {