From d69c3db5586dcc748fef714813505230fe5d46e3 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 17 Oct 2025 11:37:56 -0400 Subject: [PATCH 1/9] dnm: Test nc/quickstarts branch --- Gemfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Gemfile b/Gemfile index cc267b2e746..cbd2bfb227e 100644 --- a/Gemfile +++ b/Gemfile @@ -1,4 +1,5 @@ # To update, change version below, run bundle install, test, +# # commit Gemfile and Gemfile.lock. source 'https://rubygems.org' From adf07748873eceac6360563f82488b54604a76b7 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 17 Oct 2025 11:43:11 -0400 Subject: [PATCH 2/9] fix syntax --- .github/workflows/zip.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index 1ed20a09658..db2a305ce69 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -271,7 +271,7 @@ jobs: strategy: matrix: os: [macos-15] - artifact: [Firebase-actions-dir] , Firebase-actions-dir-dynamic] + artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic] include: - os: macos-15 xcode: Xcode_16.4 From 86123e8b5950ea8f41788716af2fc5ca43c88bbd Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 17 Oct 2025 14:20:04 -0400 Subject: [PATCH 3/9] Some fixes --- .github/workflows/inappmessaging.yml | 1 + .github/workflows/release.yml | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index 9275f825492..0fdc367fac5 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -79,5 +79,6 @@ jobs: setup_command: scripts/setup_quickstart_spm.sh inappmessaging plist_src_path: scripts/gha-encrypted/qs-inappmessaging.plist.gpg plist_dst_path: quickstart-ios/inappmessaging/GoogleService-Info.plist + run_tests: false secrets: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 92a71e0f392..8198b9caf3b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -72,7 +72,7 @@ jobs: - product: Messaging run_tests: false - product: InAppMessaging - run_tests: true + run_tests: false - product: Firestore run_tests: false - product: Database @@ -82,7 +82,7 @@ jobs: - product: Crashlytics run_tests: true - product: ABTesting - run_tests: true + run_tests: false name: 'quickstart (release, ${{ matrix.product }}, run_tests: ${{ matrix.run_tests }})' env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} From 3baf491b921592ac572b81102cc3d5b6b457a2d7 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 17 Oct 2025 14:31:05 -0400 Subject: [PATCH 4/9] progress --- .github/workflows/zip.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index db2a305ce69..bf9d85b44d0 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -579,8 +579,6 @@ jobs: - name: Install Secret GoogleService-Info.plist run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \ quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret" - - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - name: Test Swift Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - uses: actions/upload-artifact@v4 @@ -633,8 +631,6 @@ jobs: quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret" - name: Test Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Test Swift Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - uses: actions/upload-artifact@v4 if: failure() with: From 4eb96d20c19564442879bb19663b1871405656f9 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 17 Oct 2025 14:35:59 -0400 Subject: [PATCH 5/9] address comment manually --- .github/workflows/zip.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index bf9d85b44d0..e27b5eaf70c 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -247,13 +247,6 @@ jobs: quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret" - name: Test Quickstart run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") - - name: Remove data before upload - if: always() - run: scripts/remove_data.sh abtesting - # - uses: actions/upload-artifact@v4 - # if: failure() - # with: - # name: quickstart_artifacts_abtesting - uses: actions/upload-artifact@v4 if: failure() with: From d683df8d4ce8571d7a18d84d508d4ab1ea1dde39 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 17 Oct 2025 14:38:54 -0400 Subject: [PATCH 6/9] remove comms --- .github/workflows/zip.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index e27b5eaf70c..e970b699e1b 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -9,8 +9,6 @@ # zip from the current commit (HEAD). name: zip -# TODO(ncooke3): Add FirebaseAI test. - permissions: actions: read contents: read From 844c0f7d0eb5878b74c9dcbf76d4ca6f7c1f50f9 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 20 Oct 2025 10:25:18 -0400 Subject: [PATCH 7/9] database --- .github/workflows/zip.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index e970b699e1b..d5eec14bbcf 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -464,7 +464,7 @@ jobs: run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \ quickstart-ios/database/GoogleService-Info.plist "$plist_secret" - name: Test Quickstart - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}") + run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift) - uses: actions/upload-artifact@v4 if: failure() with: From ce05f3ca6c9f9f9fc3ffca71bddc2521af8fc5e8 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Wed, 22 Oct 2025 11:18:22 -0400 Subject: [PATCH 8/9] analytics fix --- .github/workflows/release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8198b9caf3b..9dc14d9d904 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -15,6 +15,7 @@ on: env: FIREBASE_CI: true + FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: true concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} From 48df192783fccccd8950535a82125b7ce754285b Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Wed, 22 Oct 2025 11:46:54 -0400 Subject: [PATCH 9/9] Apply suggestion from @ncooke3 --- .github/workflows/zip.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index d5eec14bbcf..a5bc5c9bab2 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -453,7 +453,7 @@ jobs: find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} + - uses: actions/checkout@v4 - name: Setup quickstart - run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \ + run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \ "${HOME}"/ios_frameworks/Firebase/FirebaseDatabase/* \ "${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \ "${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \